Code review comment for ~tcuthbert/charm-grafana:master

I've reviewed the change and it lgtm. However, we still need to support Grafana v6, which is available via snap. I've suggested a MP to merge against your repo [1]

OTOH, once it is merged (if you agree), I would recommend rebasing from master as I see conflicts with the main branch. I did so locally and also had to add an extra relation in base.yaml, and all tests passed (see [2]).

Let me know what you think. With these changes, I think it would be ready to merge.

Thank you.

1. https://code.launchpad.net/~aluria/charm-grafana/+git/grafana-charm-1/+merge/387944
2. https://pastebin.ubuntu.com/p/zRCPjGp7NH/