Code review comment for lp:~tblue/quam-plures/plugins_multiple_instances

Revision history for this message
EdB (edb) wrote :

Testing now, so far so good, but reading my comment above made me delete the original. I had already deleted #2 of 4 instances and installed #5 successfully. Now I deleted the original. In other words I have "MyPlugin #3" through #5 - 3 cases of it with those numbers as names.

I clicked on "Install new" and it offers me "MyPlugin #4" which while technically is accurate because it would be the fourth it still seems wrong because a plugin with that name already exists. ACTUALLY INSTALLING IT gives me "MyPlugin #6 which is what we would expect. Is this something you think you can improve on?

That is not a show-stopper by the way - just an observation. I am leaving this as a comment only because I have not actually looked at the code. All I've done is take it out for a test run. So far I'm on the way to marking this approved, but would be even happier if the tiny little issue described can be somehow improved.

« Back to merge proposal