Merge lp:~taynaud/gephi/statistics-correction into lp:~gephi.team/gephi/0.8
Proposed by
Thomas Aynaud
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sébastien Heymann | ||||
Approved revision: | 2224 | ||||
Merge reported by: | Sébastien Heymann | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~taynaud/gephi/statistics-correction | ||||
Merge into: | lp:~gephi.team/gephi/0.8 | ||||
Diff against target: |
163 lines (+14/-39) 1 file modified
StatisticsPlugin/src/org/gephi/statistics/plugin/Modularity.java (+14/-39) |
||||
To merge this branch: | bzr merge lp:~taynaud/gephi/statistics-correction | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sébastien Heymann | Approve | ||
Review via email: mp+61108@code.launchpad.net |
Description of the change
Correct a bug in modularity optimisation.
The Louvain algorithm study node one by one, and for each node :
remove it from its community
look for any neighboring community and select the one which maximizes modularity gain
put the node into this community.
The implemented algorithm was not removing the node from its community, resulting in a wrong gain computation. Now, the algorithm still not remove the node from its community (which would be slow with the current implementation) but compute the gain accurately.
There was also an issue with self loops counted twice.
To post a comment you must log in.
Merged on rev 2222