Code review comment for ~tasdomas/influxdb-charm:d01-actions-fix

Revision history for this message
Tom Haddon (mthaddon) wrote :

This creates a number of lint errors:

$ make lint
./actions/create-database:8:1: E402 module level import not at top of file
./actions/create-database:11:1: E402 module level import not at top of file
./actions/create-database:12:1: E402 module level import not at top of file
./actions/create-database:14:1: E402 module level import not at top of file
./actions/create-user:8:1: E402 module level import not at top of file
./actions/create-user:11:1: E402 module level import not at top of file
./actions/create-user:12:1: E402 module level import not at top of file
./actions/create-user:13:1: E402 module level import not at top of file
./actions/create-user:14:1: E402 module level import not at top of file
./actions/create-user:16:1: E402 module level import not at top of file
./actions/grant-privilege:8:1: E402 module level import not at top of file
./actions/grant-privilege:11:1: E402 module level import not at top of file
./actions/grant-privilege:12:1: E402 module level import not at top of file
./actions/grant-privilege:14:1: E402 module level import not at top of file
./actions/show-admin-password:7:1: E402 module level import not at top of file
./actions/show-admin-password:10:1: E402 module level import not at top of file
./actions/show-admin-password:10:1: F401 'os' imported but unused
./actions/show-admin-password:11:1: E402 module level import not at top of file
./lib/influxdbcharmlib.py:36:78: W291 trailing whitespace
./lib/influxdbcharmlib.py:37:78: W291 trailing whitespace

It looks like not all of those are you changes, but could those be addressed as part of this?

review: Needs Fixing

« Back to merge proposal