Merge lp:~tapaal-contributor/tapaal/merge-components-changed-lens-1947689 into lp:tapaal

Proposed by Lena Ernstsen
Status: Merged
Approved by: Jiri Srba
Approved revision: 1156
Merged at revision: 1156
Proposed branch: lp:~tapaal-contributor/tapaal/merge-components-changed-lens-1947689
Merge into: lp:tapaal
Diff against target: 25 lines (+2/-2)
2 files modified
src/dk/aau/cs/gui/TabContent.java (+1/-1)
src/pipe/gui/widgets/QueryDialog.java (+1/-1)
To merge this branch: bzr merge lp:~tapaal-contributor/tapaal/merge-components-changed-lens-1947689
Reviewer Review Type Date Requested Status
Jiri Srba Approve
Review via email: mp+411398@code.launchpad.net

This proposal supersedes a proposal from 2021-10-25.

Commit message

Fixed wrong use of lens with merge net components

To post a comment you must log in.
Revision history for this message
Jiri Srba (srba) wrote : Posted in a previous version of this proposal

The problem is not fixed. Open e.g. the intro example and change it to untimed net. Then open the query and advanced view and "merge net components". It will open a new merged net that is not both timed and it is also a game.

review: Needs Fixing
Revision history for this message
Jiri Srba (srba) wrote :

Tested and fixes the problem.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/dk/aau/cs/gui/TabContent.java'
--- src/dk/aau/cs/gui/TabContent.java 2021-11-03 11:55:06 +0000
+++ src/dk/aau/cs/gui/TabContent.java 2021-11-05 06:35:54 +0000
@@ -1978,7 +1978,7 @@
19781978
1979 network.add(transformedModel.value1());1979 network.add(transformedModel.value1());
19801980
1981 NetWriter tapnWriter = new TimedArcPetriNetNetworkWriter(network, templates, new ArrayList<pipe.dataLayer.TAPNQuery>(0), network.constants());1981 NetWriter tapnWriter = new TimedArcPetriNetNetworkWriter(network, templates, new ArrayList<pipe.dataLayer.TAPNQuery>(0), network.constants(), lens);
19821982
1983 try {1983 try {
1984 ByteArrayOutputStream outputStream = tapnWriter.savePNML();1984 ByteArrayOutputStream outputStream = tapnWriter.savePNML();
19851985
=== modified file 'src/pipe/gui/widgets/QueryDialog.java'
--- src/pipe/gui/widgets/QueryDialog.java 2021-10-16 18:20:43 +0000
+++ src/pipe/gui/widgets/QueryDialog.java 2021-11-05 06:35:54 +0000
@@ -3764,7 +3764,7 @@
37643764
3765 network.add(transformedModel.value1());3765 network.add(transformedModel.value1());
37663766
3767 NetWriter tapnWriter = new TimedArcPetriNetNetworkWriter(network, templates, new ArrayList<pipe.dataLayer.TAPNQuery>(0), new ArrayList<Constant>(0));3767 NetWriter tapnWriter = new TimedArcPetriNetNetworkWriter(network, templates, new ArrayList<pipe.dataLayer.TAPNQuery>(0), new ArrayList<Constant>(0), lens);
37683768
3769 try {3769 try {
3770 ByteArrayOutputStream outputStream = tapnWriter.savePNML();3770 ByteArrayOutputStream outputStream = tapnWriter.savePNML();

Subscribers

People subscribed via source and target branches