Code review comment for lp:~tapaal-contributor/tapaal/cpn-gui-dev

Revision history for this message
Kenneth Yrke Jørgensen (yrke) wrote :

File: ColoredArcGuardPanel.java
Function deleteSelections(), line 752

This "if" seems to have an flow error:

if (currentSelection.getObject() instanceof ArcExpression) {
    replacement = getSpecificChildOfProperty(1, currentSelection.getObject());
}
else if (currentSelection.getObject() instanceof ArcExpression) {
    replacement = new PlaceHolderColorExpression();
}

Second branch can't be reached, as it has the same guad as first branch. This must be a logical error.

« Back to merge proposal