Code review comment for lp:~tapaal-approx/tapaal/tapaal-approx-new

Revision history for this message
Jiri Srba (srba) wrote :

I tried to make a summary of what should be done with suggested solutions so that
we can merge this branch to trunk asap (other branches are waiting on this merge at the moment).

1. Issue with long methods that should be split into more functions.
   (Not essential for merge, could be done in a separate branch and I could put it
    on the bug list unless someone will take a look at this before the merge).

2. s.append issues by Kenneth is in other code as well; I suggest not to fix it in this
   branch and make a separate branch for this (I will make a bug report so that we do not forget).

3. TAPNComposerExtended should be renamed to TAPNComposedWithGUI. Could the normal be
   replaced with the one with GUI or use inheritance as Jakob suggested? Looking forward
   to hear options on this.

4. The memory monitor is buggy at the moment and should be changed according to Mathias' suggestion
   (extra argument that would signal that it is a commulative memory monitor). See the
   issue in the comment just above.

Please, react to those comments so that we can merge it asap. Thanks.

« Back to merge proposal