Code review comment for lp:~tapaal-approx/tapaal/tapaal-approx-new

Revision history for this message
Jakob Taankvist (jakob-taankvist) wrote :

I've looked through the code and one think i think should be fixed are some very long functions. Is it possible to split these into multiple functions in a logical way? Very long functions are e.g.:

makeTraceTAPN lines: 93 - 275
modifyTAPN lines: 315 - 421
verify lines: 2557 - 2841
doInBackground lines: 3135 - 3468

I also noticed a lot of nesting of for and if in these functions, it would be nice if could somehow be avoided:
reduceTraceForOriginalNet and removeTokens lines: 1084 - 1115

Some of the code in the action listener in lines 4020 - 4062 should maybe be done in the composer class - at least I think it's a very long action listener, which might make it hard to use the composer in other parts of the code later. (an option would be to move the code to a function somewhere logical, and then calling this function from the action listener).

« Back to merge proposal