Code review comment for lp:~tamura-yoshiaki/nova/bug-764236

Revision history for this message
termie (termie) wrote :

Looks like you've got a couple pep8 errors in there still, you may want to use again or grab this helper (i have a merge prop out to add it ./tools/

Also, pep8 doesn't appear to catch the extra whitespaces on the first line of ip_dict (diff line 28), between the key and the value.

Could you move the contents of the mapping dict up a line so that they begin on the same line as the mapping declaration (like ip_dict above it)?

Your test looks like it verifies your code, so works for me :)

review: Needs Fixing

« Back to merge proposal