Code review comment for ~tamilmani1989/cloud-init:azure_networking

> > Can you describe in what scenario the current code which polls the IMDS url
> > for failures is inadequate?
> >
> > Is there a way we can test the current code on Azure directly?
>
> Thanks Ryan, This is a valid question, and we are in process of testing in
> Azure with all components involved (including updated host). Having said that,
> IMDS poll can fail for multiple reasons, e.g., IMDS in the middle of getting
> updated on the host, or any random communication failure (since this is a
> network call).

Which of these failures are not handled already by the retry logic? If we have any failure attempting to fetch the URL from IMDS, then then the retry logic will acquire a new lease; so I'm struggling to see which scenario is not covered.

> I think relying on a clean deterministic event should be preferred.

I agree; I'd much rather see use of the HyperV Keystore here for indicating both that a VM has been tagged as pre-provision, and when its network has been moved.

> Furthermore, I believe the code that polls host for new provisioning data
> should just do that, and not worry about setting up networking.

The _poll_imds is not setting up networking for the system; rather it's setting up a temporary interface and DHCP'ing on to acquire information at a specific time for a specific use-case: preprovisioning.