Code review comment for lp:~takluyver/unattended-upgrades/py3

Revision history for this message
Barry Warsaw (barry) wrote :

Oh also, the conversion to bytes in send_summary_mail() isn't right. It's generally accepted wisdom that in Python 3, Popen() should be passed universal_newlines=True which gives you unicodes. I think that's the right thing to do in this case.

« Back to merge proposal