Code review comment for lp:~takluyver/ubuntu/quantal/python-tz/merge-py3

On May 22, 2012, at 09:44 PM, Thomas Kluyver wrote:

>- Missing license description for 'public domain' - the Debian manual says
> that the description should contain details of exactly what exemptions from
> copyright are made [1]. I had no involvement in making the timezone
> database, and the webpage about it just describes it as "the public domain
> time zone database"[2], so I don't know what details I can put.

Okay, we'll leave this one alone.

>- debian/rules structure: Is it worth restructuring just for Ubuntu, given
> that it will make a new diff against Debian's version? I'd prefer to keep
> the diff as small as practical, so that future merges are easy.

It's a good question. Given that Ubuntu's python-tz is so far ahead of Debian
(which in itself is unfortunate), it might be worth making our package conform
to current standards, and then try to push those changes back to Debian. But
I can be convinced otherwise, if it makes merging whatever meager bits we
still can from Debian.

>- Tests: They were disabled in Ubuntu earlier this year, a day after they
> were enabled [3]. Chuck doesn't give a reason in the commit message, but I
> assume he had one.

I talked to Chuck on IRC about this one. I says that the tests got
re-disabled almost immediately because they weren't actually testing
python-tz. He wasn't sure what the tests were actually testing. So I guess
we can leave this one alone too.

Okay, I think it's worth getting Python 3 support to go ahead and do the
merge. I'll sponsor that. Eventually it would be good to modernize the
Debian package (with the d/rules improvements), but we can worry about that
later. Perhaps you'd care to file a bug with Debian on that?