Code review comment for lp:~takluyver/ubuntu/quantal/python-tz/merge-py3

Revision history for this message
Thomas Kluyver (takluyver) wrote :

Thanks, Barry

A few questions:

- Missing license description for 'public domain' - the Debian manual says that the description should contain details of exactly what exemptions from copyright are made [1]. I had no involvement in making the timezone database, and the webpage about it just describes it as "the public domain time zone database"[2], so I don't know what details I can put.

- debian/rules structure: Is it worth restructuring just for Ubuntu, given that it will make a new diff against Debian's version? I'd prefer to keep the diff as small as practical, so that future merges are easy.

- Tests: They were disabled in Ubuntu earlier this year, a day after they were enabled [3]. Chuck doesn't give a reason in the commit message, but I assume he had one.

[1] http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#public-domain
[2] http://www.iana.org/time-zones/repository/tz-link.html
[3] http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/python-tz/quantal/revision/27

« Back to merge proposal