Merge lp:~system76-dev/ubiquity/trunk into lp:ubiquity

[Jeremy Soller]

- Add WPA-2 enterprise support using libnm-gtk
- Remove password box from GTK installer, using libnm-gtk for any secure connections

This patch to `libnm-gtk` must also be applied: https://bugs.launchpad.net/ubuntu/+source/network-manager-applet/+bug/1667129

[lp:~system76-dev/ubiquity/trunk]

6525. By Jeremy Soller on 2017-03-07

Switch to using libnma

6526. By Jeremy Soller on 2017-03-07

Fixes for use of libnma

6527. By Jeremy Soller on 2017-03-07

Change RemoteConnection to SimpleConnection

[Mathieu Trudel-Lapierre (cyphermox)]

Looks fine to me code-wise; now I'll merge and review functionally.

[Mathieu Trudel-Lapierre (cyphermox)]

How did you test this? I've built this in my PPA, and installing it on a live session leads to ubiquity not starting the wireless panel at all (I expected it to still show a list of wireless networks).

review: Needs Information

[lp:~system76-dev/ubiquity/trunk]

6528. By Jeremy Soller on 2017-06-16

Merge

6529. By Jeremy Soller on 2017-06-20

Update changelog

[Jeremy Soller (jackpot51)]

cyphermox, the wireless network page is skipped if you are connected to a wired network.

[lp:~system76-dev/ubiquity/trunk]

6530. By Jeremy Soller on 2017-06-22

Merge

6531. By Jeremy Soller on 2017-06-22

Update changelog

6532. By Jeremy Soller on 2017-06-22

Revert manifest to zesty versions

=== modified file 'd-i/manifest'
--- d-i/manifest	2017-04-07 14:17:15 +0000
+++ d-i/manifest	2017-06-22 16:34:36 +0000
@@ -1,15 +1,15 @@
 apt-setup 1:0.104ubuntu5
 base-installer 1.158ubuntu4
 bterm-unifont 1.4
-choose-mirror 2.78ubuntu1
+choose-mirror 2.75ubuntu1
 clock-setup 0.131ubuntu1
 console-setup 1.142ubuntu5
 debian-installer-utils 1.113ubuntu1
 flash-kernel 3.0~rc.4ubuntu65
 grub-installer 1.128ubuntu7
-hw-detect 1.117ubuntu4
+hw-detect 1.117ubuntu3
 localechooser 2.65ubuntu4
-netcfg 1.138ubuntu5
+netcfg 1.138ubuntu4
 partconf 1.50
 partman-auto 134ubuntu6
 partman-auto-crypto 22ubuntu1
@@ -24,6 +24,7 @@
 partman-ext3 86ubuntu1
 partman-jfs 47
 partman-lvm 113
+partman-newworld 34
 partman-partitioning 114ubuntu2
 partman-swapfile 1
 partman-target 98ubuntu1
@@ -32,3 +33,4 @@
 preseed 1.71ubuntu4
 tzsetup 1:0.81ubuntu1
 user-setup 1.63ubuntu4
+yaboot-installer 1.1.36ubuntu1

=== modified file 'debian/changelog'
--- debian/changelog	2017-04-10 02:36:04 +0000
+++ debian/changelog	2017-06-22 16:34:36 +0000
@@ -1,3 +1,9 @@
+ubiquity (17.04.10~system76~1) zesty; urgency=medium
+
+  * Fix for crashes when selecting a WPA 2 enterprise network
+
+ -- Jeremy Soller <[e-mail]>  Fri, 16 Jun 2017 09:55:28 -0600
+
 ubiquity (17.04.9) zesty; urgency=medium
 
   * tests/test_misc.py: Really fix test for the 'ta' keymap: check for

=== modified file 'debian/control'
--- debian/control	2016-09-26 19:16:34 +0000
+++ debian/control	2017-06-22 16:34:36 +0000
@@ -45,7 +45,7 @@
 Package: ubiquity-frontend-gtk
 Architecture: amd64 arm64 armhf i386 powerpc ppc64el
 Pre-Depends: ${misc:Pre-Depends}
-Depends: ${shlibs:Depends}, ${misc:Depends}, ${python3:Depends}, ubiquity (= ${binary:Version}), python3-dbus, gir1.2-gtk-3.0 (>= 3.20), gir1.2-pango-1.0, gir1.2-soup-2.4, gir1.2-vte-2.91, gir1.2-webkit2-4.0, iso-codes, metacity | marco | xfwm4 | matchbox-window-manager | lubuntu-default-settings | openbox | gnome-shell, gir1.2-xkl-1.0, gir1.2-timezonemap-1.0, python3-gi, python3-cairo, python3-gi-cairo, gir1.2-appindicator3-0.1, busybox-static | busybox
+Depends: ${shlibs:Depends}, ${misc:Depends}, ${python3:Depends}, ubiquity (= ${binary:Version}), python3-dbus, gir1.2-gtk-3.0 (>= 3.20), gir1.2-nma-1.0, gir1.2-pango-1.0, gir1.2-soup-2.4, gir1.2-vte-2.91, gir1.2-webkit2-4.0, iso-codes, metacity | marco | xfwm4 | matchbox-window-manager | lubuntu-default-settings | openbox | gnome-shell, gir1.2-xkl-1.0, gir1.2-timezonemap-1.0, python3-gi, python3-cairo, python3-gi-cairo, gir1.2-appindicator3-0.1, busybox-static | busybox
 Suggests: gnome-control-center | feh
 Conflicts: ubuntu-express-frontend-gtk, espresso-frontend-gtk, ubiquity (<< 2.4.3)
 Replaces: ubuntu-express-frontend-gtk, espresso-frontend-gtk, ubiquity (<< 2.4.3)

=== modified file 'tests/test_wireless.py'
--- tests/test_wireless.py	2012-07-16 14:29:13 +0000
+++ tests/test_wireless.py	2017-06-22 16:34:36 +0000
@@ -4,7 +4,7 @@
 
 import mock
 
-from ubiquity import gtkwidgets, nm, plugin_manager
+from ubiquity import nm, plugin_manager
 
 
 class WirelessTests(unittest.TestCase):
@@ -22,20 +22,3 @@
         self.manager = self.nmwidget.view.wifi_model
         self.model = self.manager.model
         self.manager.passphrases_cache = {}
-
-    @mock.patch('ubiquity.nm.NetworkManager.is_connected')
-    def test_secure_ap_can_enter_password(self, is_connected):
-        is_connected.return_value = False
-        iterator = self.model.append(None, ['/foo', 'Intel', 'Wireless'])
-        iterator_insecure = self.model.append(iterator, ['Insecure', False, 0])
-        iterator_secure = self.model.append(iterator, ['Secure', True, 0])
-        gtkwidgets.refresh()
-        self.assertFalse(self.nmwidget.hbox.get_sensitive())
-        self.nmwidget.view.set_cursor(
-            self.model.get_path(iterator_secure), None, False)
-        gtkwidgets.refresh()
-        self.assertTrue(self.nmwidget.hbox.get_sensitive())
-        self.nmwidget.view.set_cursor(
-            self.model.get_path(iterator_insecure), None, False)
-        gtkwidgets.refresh()
-        self.assertFalse(self.nmwidget.hbox.get_sensitive())

=== modified file 'ubiquity/frontend/gtk_components/nmwidgets.py'
--- ubiquity/frontend/gtk_components/nmwidgets.py	2016-12-01 14:00:11 +0000
+++ ubiquity/frontend/gtk_components/nmwidgets.py	2017-06-22 16:34:36 +0000
@@ -1,11 +1,10 @@
-import string
-
 from dbus.mainloop.glib import DBusGMainLoop
 DBusGMainLoop(set_as_default=True)
 
 from gi.repository import Gtk, GObject, GLib
+from gi.repository import NM, NMA
 
-from ubiquity.nm import QueuedCaller, NetworkStore, NetworkManager
+from ubiquity.nm import decode_ssid, QueuedCaller, NetworkStore, NetworkManager
 
 
 class GLibQueuedCaller(QueuedCaller):
@@ -92,9 +91,8 @@
 class NetworkManagerTreeView(Gtk.TreeView):
     __gtype_name__ = 'NetworkManagerTreeView'
 
-    def __init__(self, password_entry=None, state_changed=None):
+    def __init__(self, state_changed=None):
         Gtk.TreeView.__init__(self)
-        self.password_entry = password_entry
         self.configure_icons()
         model = GtkNetworkStore()
         model.set_sort_column_id(0, Gtk.SortType.ASCENDING)
@@ -102,6 +100,10 @@
         self.wifi_model = NetworkManager(model,
                                          GLibQueuedCaller,
                                          state_changed)
+
+        self.nm_client = None
+        self.nm_connection = None
+
         self.set_model(model)
 
         ssid_column = Gtk.TreeViewColumn('')
@@ -157,17 +159,21 @@
                 self.expand_row(path, False)
             i = model.iter_next(i)
 
+    def row_activated(self, unused, path, column):
+        self.connect_to_selection()
+
     def get_state(self):
         return self.wifi_model.get_state()
 
     def disconnect_from_ap(self):
-        self.wifi_model.disconnect_from_ap()
+        if self.nm_connection:
+            if not self.nm_client:
+                self.nm_client = NM.Client.new()
 
-    def row_activated(self, unused, path, column):
-        passphrase = None
-        if self.password_entry:
-            passphrase = self.password_entry.get_text()
-        self.connect_to_selection(passphrase)
+            self.nm_client.deactivate_connection(self.nm_connection)
+            self.nm_connection = None
+        else:
+            self.wifi_model.disconnect_from_ap()
 
     def configure_icons(self):
         it = Gtk.IconTheme()
@@ -220,13 +226,6 @@
         else:
             cell.set_property('text', ssid)
 
-    def get_passphrase(self, ssid):
-        try:
-            cached = self.wifi_model.passphrases_cache[ssid]
-        except KeyError:
-            return ''
-        return cached
-
     def is_row_an_ap(self):
         model, iterator = self.get_selection().get_selected()
         if iterator is None:
@@ -244,12 +243,72 @@
         else:
             return False
 
-    def connect_to_selection(self, passphrase):
+    def find_ap(self, device, ssid):
+        for ap in device.get_access_points():
+            ap_ssid = ap.get_ssid()
+            if ap_ssid and decode_ssid(ap_ssid.get_data()) == ssid:
+                return ap
+        return None
+
+    def connect_cb(self, client, result, user_data):
+        self.nm_connection = client.add_and_activate_connection_finish(result)
+
+    def connect_dialog_cb(self, dialog, response):
+        if response == Gtk.ResponseType.OK:
+            connection, device, ap = dialog.get_connection()
+
+            if not self.nm_client:
+                self.nm_client = NM.Client.new()
+
+            self.nm_client.add_and_activate_connection_async(
+                connection, device, None, None, self.connect_cb, None
+            )
+        dialog.hide()
+
+    def connect_to_selection(self):
         model, iterator = self.get_selection().get_selected()
-        ssid = model[iterator][0]
+        if iterator is None:
+            return
         parent = model.iter_parent(iterator)
         if parent:
-            self.wifi_model.connect_to_ap(model[parent][0], ssid, passphrase)
+            try:
+                devid = model[parent][0]
+                ssid = model[iterator][0]
+                if model[iterator][1]:
+                    if not self.nm_client:
+                        self.nm_client = NM.Client.new()
+
+                    device = self.nm_client.get_device_by_path(devid)
+                    ap = self.find_ap(device, ssid)
+
+                    connection = NM.SimpleConnection()
+                    connection.add_setting(NM.SettingConnection(
+                        uuid=NM.utils_uuid_generate()
+                    ))
+                    connection.add_setting(NM.SettingWireless(
+                        ssid=ap.get_property("ssid")
+                    ))
+
+                    dialog = NMA.WifiDialog.new(
+                        self.nm_client,
+                        connection,
+                        device,
+                        ap,
+                        False
+                    )
+                    dialog.connect("response", self.connect_dialog_cb)
+                    dialog.run()
+                else:
+                    self.wifi_model.connect_to_ap(devid, ssid)
+            except Exception as e:
+                dialog = Gtk.MessageDialog(
+                    None, Gtk.DialogFlags.MODAL,
+                    Gtk.MessageType.ERROR, Gtk.ButtonsType.CLOSE,
+                    "Failed to connect to wireless network"
+                )
+                dialog.format_secondary_text("{}".format(e))
+                dialog.run()
+                dialog.hide()
 
 
 GObject.type_register(NetworkManagerTreeView)
@@ -262,44 +321,23 @@
             GObject.SignalFlags.RUN_FIRST, GObject.TYPE_NONE,
             (GObject.TYPE_UINT,)),
         'selection_changed': (
-            GObject.SignalFlags.RUN_FIRST, GObject.TYPE_NONE, ()),
-        'pw_validated': (
-            GObject.SignalFlags.RUN_FIRST, GObject.TYPE_NONE,
-            (GObject.TYPE_BOOLEAN,))}
+            GObject.SignalFlags.RUN_FIRST, GObject.TYPE_NONE, ())}
 
     def __init__(self):
         Gtk.Box.__init__(self)
         self.set_orientation(Gtk.Orientation.VERTICAL)
         self.set_spacing(12)
-        self.password_entry = Gtk.Entry()
-        self.view = NetworkManagerTreeView(self.password_entry,
-                                           self.state_changed)
+        self.view = NetworkManagerTreeView(self.state_changed)
         scrolled_window = Gtk.ScrolledWindow()
         scrolled_window.set_policy(
             Gtk.PolicyType.NEVER, Gtk.PolicyType.AUTOMATIC)
         scrolled_window.set_shadow_type(Gtk.ShadowType.IN)
         scrolled_window.add(self.view)
         self.pack_start(scrolled_window, True, True, 0)
-        self.hbox = Gtk.Box(spacing=6)
-        self.pack_start(self.hbox, False, True, 0)
-        self.password_label = Gtk.Label(label='Password:')
-        self.password_entry.set_visibility(False)
-        self.password_entry.connect('activate', self.connect_to_ap)
-        self.password_entry.connect('changed', self.password_entry_changed)
-        self.display_password = Gtk.CheckButton(label='Display password')
-        self.display_password.connect('toggled', self.display_password_toggled)
-        self.hbox.pack_start(self.password_label, False, True, 0)
-        self.hbox.pack_start(self.password_entry, True, True, 0)
-        self.hbox.pack_start(self.display_password, False, True, 0)
-        self.hbox.set_sensitive(False)
         self.selection = self.view.get_selection()
         self.selection.connect('changed', self.changed)
         self.show_all()
 
-    def translate(self, password_label_text, display_password_text):
-        self.password_label.set_label(password_label_text)
-        self.display_password.set_label(display_password_text)
-
     def get_state(self):
         return self.view.get_state()
 
@@ -315,48 +353,16 @@
     def state_changed(self, state):
         self.emit('connection', state)
 
-    def password_is_valid(self):
-        passphrase = self.password_entry.get_text()
-        if len(passphrase) >= 8 and len(passphrase) < 64:
-            return True
-        if len(passphrase) == 64:
-            for c in passphrase:
-                if c not in string.hexdigits:
-                    return False
-            return True
-        else:
-            return False
-
     def connect_to_ap(self, *args):
-        if self.password_is_valid():
-            passphrase = self.password_entry.get_text()
-            self.view.connect_to_selection(passphrase)
+        self.view.connect_to_selection()
 
     def disconnect_from_ap(self):
         self.view.disconnect_from_ap()
 
-    def password_entry_changed(self, *args):
-        self.emit('pw_validated', self.password_is_valid())
-
-    def display_password_toggled(self, *args):
-        self.password_entry.set_visibility(self.display_password.get_active())
-
     def changed(self, selection):
         iterator = selection.get_selected()[1]
         if not iterator:
             return
-        row = selection.get_tree_view().get_model()[iterator]
-        secure = row[1]
-        ssid = row[0]
-        if secure:
-            self.hbox.set_sensitive(True)
-            passphrase = self.view.get_passphrase(ssid)
-            self.password_entry.set_text(passphrase)
-            self.emit('pw_validated', False)
-        else:
-            self.hbox.set_sensitive(False)
-            self.password_entry.set_text('')
-            self.emit('pw_validated', True)
         self.emit('selection_changed')
 
 

=== modified file 'ubiquity/frontend/kde_components/nmwidgets.py'
--- ubiquity/frontend/kde_components/nmwidgets.py	2016-10-06 14:29:28 +0000
+++ ubiquity/frontend/kde_components/nmwidgets.py	2017-06-22 16:34:36 +0000
@@ -272,7 +272,13 @@
 
     def connect_to_selection(self, passphrase):
         devid, ssid = self._get_selected_row_ids()
-        self.wifi_model.connect_to_ap(devid, ssid, passphrase)
+        try:
+            self.wifi_model.connect_to_ap(devid, ssid, passphrase)
+        except Exception as e:
+            dialog = QtWidgets.QMessageBox()
+            dialog.setWindowTitle("Failed to connect to wireless network")
+            dialog.setText("{}".format(e))
+            dialog.exec_()
 
     def get_cached_passphrase(self):
         index = self.currentIndex()

=== modified file 'ubiquity/plugins/ubi-wireless.py'
--- ubiquity/plugins/ubi-wireless.py	2016-10-06 03:27:02 +0000
+++ ubiquity/plugins/ubi-wireless.py	2017-06-22 16:34:36 +0000
@@ -84,7 +84,6 @@
         self.nmwidget = builder.get_object('nmwidget')
         self.nmwidget.connect('connection', self.state_changed)
         self.nmwidget.connect('selection_changed', self.selection_changed)
-        self.nmwidget.connect('pw_validated', self.pw_validated)
         self.no_wireless = builder.get_object('no_wireless')
         self.use_wireless = builder.get_object('use_wireless')
         self.use_wireless.connect('toggled', self.wireless_toggled)
@@ -99,10 +98,6 @@
 
     def plugin_translate(self, lang):
         get_s = self.controller.get_string
-        label_text = get_s('ubiquity/text/wireless_password_label')
-        display_text = get_s('ubiquity/text/wireless_display_password')
-        self.nmwidget.translate(label_text, display_text)
-
         self.connect_text = get_s('ubiquity/text/connect', lang)
         self.stop_text = get_s('ubiquity/text/stop', lang)
         frontend = self.controller._wizard
@@ -141,7 +136,6 @@
             frontend.connecting_spinner.stop()
             frontend.connecting_label.hide()
             frontend.translate_widget(frontend.next)
-            self.nmwidget.hbox.set_sensitive(False)
             self.next_normal = True
             self.controller.allow_go_forward(True)
 
@@ -179,7 +173,6 @@
             frontend.connecting_spinner.hide()
             frontend.connecting_spinner.stop()
             frontend.connecting_label.hide()
-            self.controller.allow_go_forward(True)
 
             frontend.translate_widget(frontend.back)
             self.back_normal = True
@@ -196,9 +189,6 @@
             frontend.back.set_sensitive(True)
         self.selection_changed(None)
 
-    def pw_validated(self, unused, validated):
-        self.controller.allow_go_forward(validated)
-
 
 class PageKde(WirelessPageBase):
     plugin_breadcrumb = 'ubiquity/text/breadcrumb_wireless'