Code review comment for lp:~system-apps-team/webbrowser-app/multiple-windows

Revision history for this message
Olivier Tilloy (osomon) wrote :

I replied inline to your comments.

Regarding the TODO and FIXME, yes those are things we want to address in followup branches.
There’s not much we can do about the XXX until we move to Qt 5.7 (but that doesn’t matter as we have a clean solution until then).

Regarding the tests: we already didn’t have tests for session restore with one single window, because the way autopilot drives an application makes it hard/impossible to launch it twice in the same test (whenever the application exits autopilot thinks the test is over).
Ideally, this should be tested with integration tests of course. Something to think about for a followup branch, I would say.

« Back to merge proposal