Code review comment for lp:~synerpgy/openobject-addons/hr_payroll_french_localization

Hello Yanick,

it's great to see you involved on the testing and enhancement of this new feature! If even more cool to see that you're confident and optimistic about it ^^

One comment about what you plan to do:
       -A checkbox "Employer contribution" in child rules for identifying the employer contribution rule.
=> i don't think it would be really generic having this because, i guess that, in some countries/cases we could have several rules computing the employer part (or the employer part would be divided into several contribution registers). So i feel like this checkbox would be a limitation more than a real improvement. Maybe this have to stay at the localization level...

       -Some many2one field "Basic" "Gross" "Net" in the configuration somewhere (company configuration?) which lead to Hr Salary Category object. Then I should be able to call the value of theses category on the report without make hard-link in the report itself.
=> mmh would it be a problem to search for the category having code=='BASIC'? Yes, it's a kind of hardcoded link but in the other hand, if someone change the code or delete this category the whole payroll engine will probably get down! And if it's on a function, localization modules can also override the function if they want to use something else.

       -Creation of a better payslip report. Although I still think I'll need to redefine it in l10n_fr_hr_payroll
=> this would be indeed a real nice improvement

Looking forward to see your proposal,
Quentin