Code review comment for ~sylvain-pineau/plainbox:is_snap_based_helper

Revision history for this message
Jonathan Cave (jocave) wrote :

This MR also seems to remove this censoREd module, but isn't mentioned in the description. Is that intended?

The function is_classic_snap() is defined and a variable is_classic_snap referenced, but I don't see it being set anywhere. If the variable is not going to be initialised then maybe it should be removed?

review: Needs Fixing

« Back to merge proposal