Code review comment for ~sylvain-pineau/plainbox-provider-resource:snapd_resources

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

I built the deb package for this provider locally and I can confirm the new dep is well written in the control file:

Package: plainbox-provider-resource-generic
Version: 0.31.0-1
Architecture: amd64
Maintainer: Checkbox Developers <email address hidden>
Installed-Size: 131
Depends: python3 (>= 3.2), python3-checkbox-support (>= 0.22), dmidecode, dpkg (>= 1.13), lsb-release, network-manager, udev, usbutils, python3-requests-unixsocket, libc6 (>= 2.4), libnl-3-200 (>= 3.2.7), libnl-genl-3-200 (>= 3.2.7)
Suggests: x11-server-utils, gconf2, xinput
Section: utils
Priority: optional
Homepage: http://launchpad.net/plainbox-provider-resource
Description: CheckBox generic resource jobs provider
 This package provides the generic resource jobs. It is used together
 alongside with PlainBox.
 .
 Jobs are smallest units of testing that can be performed by PlainBox.
 All jobs have an unique name. There are many types of jobs, some are fully
 automated others are fully manual.
 .
 Resources are collections of key-value data sets that are generated by
 special resource jobs. They are extensively used to indicate hardware or
 software dependencies. For example a bluetooth test may indicate it
 requires bluetooth hardware and appropriate software packages installed.

Once new builds will be available in the dev ppa, you'll see python3-requests-unixsocket installed.

review: Approve

« Back to merge proposal