Merge ~sylvain-pineau/plainbox-provider-resource/+git/plainbox-provider-resource-parts:libjson-xs-perl into ~checkbox-dev/plainbox-provider-resource/+git/plainbox-provider-resource-parts:master
Proposed by
Sylvain Pineau
| Status: | Merged |
|---|---|
| Approved by: | Sylvain Pineau |
| Approved revision: | 3686d2791c782ee609b24c6835b53e82afe550d7 |
| Merged at revision: | a40166fa79f4f2756c569b1bb94019c450059620 |
| Proposed branch: | ~sylvain-pineau/plainbox-provider-resource/+git/plainbox-provider-resource-parts:libjson-xs-perl |
| Merge into: | ~checkbox-dev/plainbox-provider-resource/+git/plainbox-provider-resource-parts:master |
| Diff against target: |
12 lines (+1/-0) 1 file modified
snapcraft.yaml (+1/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sylvain Pineau (community) | Needs Resubmitting | ||
| Jonathan Cave (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2018-11-26.
Description of the change
Add libjson-xs-perl to stage package (in p-p-r rather than p-p-c because some snaps still define their own stage packages for p-p-c to get a lighter snap, e.g on armhf).
To post a comment you must log in.
Revision history for this message
| Sylvain Pineau (sylvain-pineau) wrote | # |
review:
Needs Resubmitting
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Could you add a comment as why this is included for this part? I don't think the commit message explains it sufficiently well for someone checking this later.