Merge ~sylvain-pineau/plainbox-provider-checkbox:executable_res_wireless into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: e55795c9453501dceb784c51814307a9230d5a1b
Merged at revision: 6e896036a1659b55a3b30c03c7db335b2c1c753b
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:executable_res_wireless
Merge into: plainbox-provider-checkbox:master
Diff against target: 35 lines (+3/-3)
2 files modified
bin/disk_info (+1/-1)
units/wireless/jobs.pxu (+2/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+346716@code.launchpad.net

Description of the change

More classic fixes to rely on the executable resource job, this time to fix two wireless jobs

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/bin/disk_info b/bin/disk_info
index 5efedbd..0b45443 100755
--- a/bin/disk_info
+++ b/bin/disk_info
@@ -53,7 +53,7 @@ def main():
53 disks = 053 disks = 0
54 for line in lsblk.splitlines():54 for line in lsblk.splitlines():
55 m = pattern.match(line)55 m = pattern.match(line)
56 if not m or m.group('TYPE') != 'disk':56 if not m or m.group('TYPE') not in ('disk', 'crypt'):
57 continue57 continue
58 # Only consider MMC block devices if one of their mounted partitions is58 # Only consider MMC block devices if one of their mounted partitions is
59 # root (/)59 # root (/)
diff --git a/units/wireless/jobs.pxu b/units/wireless/jobs.pxu
index 363984a..52b2b01 100644
--- a/units/wireless/jobs.pxu
+++ b/units/wireless/jobs.pxu
@@ -389,7 +389,7 @@ plugin: shell
389category_id: com.canonical.plainbox::wireless389category_id: com.canonical.plainbox::wireless
390id: wireless/monitor_wireless_connection390id: wireless/monitor_wireless_connection
391requires:391requires:
392 package.name == 'iperf'392 executable.name == 'iperf'
393 device.category == 'WIRELESS'393 device.category == 'WIRELESS'
394user: root394user: root
395environ: WPA_BG_SSID WPA_BG_PSK SERVER_IPERF395environ: WPA_BG_SSID WPA_BG_PSK SERVER_IPERF
@@ -418,7 +418,7 @@ plugin: shell
418category_id: com.canonical.plainbox::wireless418category_id: com.canonical.plainbox::wireless
419id: wireless/monitor_wireless_connection_udp419id: wireless/monitor_wireless_connection_udp
420requires:420requires:
421 package.name == 'iperf'421 executable.name == 'iperf'
422 device.category == 'WIRELESS'422 device.category == 'WIRELESS'
423user: root423user: root
424environ: WPA_BG_SSID WPA_BG_PSK SERVER_IPERF424environ: WPA_BG_SSID WPA_BG_PSK SERVER_IPERF

Subscribers

People subscribed via source and target branches