Merge ~sylvain-pineau/plainbox-provider-checkbox:executable_res_wireless into plainbox-provider-checkbox:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: e55795c9453501dceb784c51814307a9230d5a1b
Merged at revision: 6e896036a1659b55a3b30c03c7db335b2c1c753b
Proposed branch: ~sylvain-pineau/plainbox-provider-checkbox:executable_res_wireless
Merge into: plainbox-provider-checkbox:master
Diff against target: 35 lines (+3/-3)
2 files modified
bin/disk_info (+1/-1)
units/wireless/jobs.pxu (+2/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+346716@code.launchpad.net

Description of the change

More classic fixes to rely on the executable resource job, this time to fix two wireless jobs

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/disk_info b/bin/disk_info
2index 5efedbd..0b45443 100755
3--- a/bin/disk_info
4+++ b/bin/disk_info
5@@ -53,7 +53,7 @@ def main():
6 disks = 0
7 for line in lsblk.splitlines():
8 m = pattern.match(line)
9- if not m or m.group('TYPE') != 'disk':
10+ if not m or m.group('TYPE') not in ('disk', 'crypt'):
11 continue
12 # Only consider MMC block devices if one of their mounted partitions is
13 # root (/)
14diff --git a/units/wireless/jobs.pxu b/units/wireless/jobs.pxu
15index 363984a..52b2b01 100644
16--- a/units/wireless/jobs.pxu
17+++ b/units/wireless/jobs.pxu
18@@ -389,7 +389,7 @@ plugin: shell
19 category_id: com.canonical.plainbox::wireless
20 id: wireless/monitor_wireless_connection
21 requires:
22- package.name == 'iperf'
23+ executable.name == 'iperf'
24 device.category == 'WIRELESS'
25 user: root
26 environ: WPA_BG_SSID WPA_BG_PSK SERVER_IPERF
27@@ -418,7 +418,7 @@ plugin: shell
28 category_id: com.canonical.plainbox::wireless
29 id: wireless/monitor_wireless_connection_udp
30 requires:
31- package.name == 'iperf'
32+ executable.name == 'iperf'
33 device.category == 'WIRELESS'
34 user: root
35 environ: WPA_BG_SSID WPA_BG_PSK SERVER_IPERF

Subscribers

People subscribed via source and target branches