Code review comment for lp:~sylvain-pineau/checkbox/trusted-launcher-standalone

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

14:21 < zyga> spineau_afk: you have two test failures
14:22 < zyga> spineau_afk: so first one is mock older api, you can probably work around that with just assinging stuff after you instantiate mock itself
14:22 < zyga> spineau_afk: the second failure is a bit more annoying, that's argparse incompatibility between 3.2 and 3.3
14:22 < zyga> spineau_afk: plainbox has a fix for that, look at how I resolved it, the fix is in box.py with a lenghty comment that explains why it is needed
14:22 < zyga> spineau_afk: thanks

« Back to merge proposal