Code review comment for lp:~sylvain-pineau/checkbox/story597_removable_test_for_SD

Revision history for this message
Jeff Lane  (bladernr) wrote :

Nice! Great enhancement! Here's the before and after testing I just did:

bladernr@klaatu:~/development/sylvain-mmc-test-enhancement$ ./scripts/removable_storage_test -l sdio usb scsi
--------------------
Removable devices currently mounted:
/dev/mmcblk0p1 : /media/8765-4321
/dev/sdb1 : /media/1AE8-8249
Removable devices currently not mounted:
None
--------------------
bladernr@klaatu:~/development/sylvain-mmc-test-enhancement$ ./scripts/removable_storage_test --memorycard -l sdio usb scsi
--------------------
Removable devices currently mounted:
/dev/mmcblk0p1 : /media/8765-4321
Removable devices currently not mounted:
None
--------------------

Note that sdb on my machine is a usb key... and it properly ignores the usb key!

Approve

review: Approve

« Back to merge proposal