Merge lp:~sylvain-pineau/checkbox/story482.7_screenshot_fullscreen_video into lp:checkbox

[Sylvain Pineau]

This proposal comes with a new gst_pipeline_test script which support fullscreen video playback by forcing the video sink element to use a specific Gtk Window identifier for rendering.

A new features ensures that the video playback will loop until the given timeout is reached by seeking to the first frame on EOS events.

A new job takes care of performing a still capture during a fullscreen video playback.

[Jeff Lane  (bladernr)]

I'm not comfortable with hard coding /dev/video1 into the job command like that.

On the system I tested with, I somehow ended up with three video devices:
bladernr@klaatu:~$ find /dev -name video*
/dev/video1
/dev/video0
bladernr@klaatu:~$ find /dev -name video*
/dev/video2
/dev/video1
/dev/video0

And in my system, the USB webcam I just plugged in is video2, not video1.

Also, some systems may not already have a built in webcam... for example, my Thinkpad x201:

bladernr@GarbageScow:~/Downloads$ find /dev -name video*
bladernr@GarbageScow:~/Downloads$

and after plugging in the webcam:

bladernr@GarbageScow:~/Downloads$ find /dev -name video*
/dev/video0
bladernr@GarbageScow:~/Downloads$

review: Needs Fixing

[Daniel Manrique (roadmr)]

As things continue moving towards gtk3 and gi.repository the bug will need to be addressed. We can expect some pressure to port all of our test scripts to avoid depending on python-gtk2. Once this makes it in, we need to keep an eye on the bug and on whether python-gtk2 is still on the default cd.

[Sylvain Pineau (sylvain-pineau)]

@Daniel, the latest manifest still mentions python-gtk2, so i think we're good with precise. The bug with the gi Gst version should be solved for gstreamer-0.11 or version 1. So yes, i'll keep an eye on this bug to move this code to gtk3 asap.

[Sylvain Pineau (sylvain-pineau)]

@Jeff,

I'm not super happy with the hard-coded /dev/video1 too and Javier Collado proposed to take the higher digit of video device to find the usb camera. The change will certainly be in the camera_test script. Once done, all jobs like this one (with /dev/video1) will be corrected.

[Javier Collado (javier.collado)]

@Jeff

Please find the changes Sylvain mentioned in the previous comment in this merge proposal:
https://code.launchpad.net/~javier.collado/checkbox/story482_avoid_hardcoding_device/+merge/95867

[lp:~sylvain-pineau/checkbox/story482.7_screenshot_fullscreen_video]

1294. By Sylvain Pineau on 2012-03-05

Updated job commands to use --highest-device to find the USB camera

1295. By Sylvain Pineau on 2012-03-05

typo fixed

[Marc Tardif (cr3)]

In jobs/graphics.txt.in, I see the following command:

+command:
+ gst_pipeline_test -t 20 -f "playbin2 uri=file://${CHECKBOX_SHARE}/data/video/Ogg_Theora_Video.ogv" &
+ sleep 15 && camera_test still --highest-device -f ${CHECKBOX_DATA}/screenshot_fullscreen_video.jpg -q 2>&1 | ansi_parser

So, you run a gst_pipeline_test for 20 seconds in the background and then sleep for 15 seconds before running the camera_test. Any reason why you're sleeping for such a long time?

The rest looks good though, so I'd merge after clarifying the above question.

review: Needs Information

[Sylvain Pineau (sylvain-pineau)]

I wanted the playback to run for a longer period before performing the screengrab, maximizing the chance to find a bug. As the file is just a 4s sample, looping/waiting 15s seemed to me quite reasonable

[Marc Tardif (cr3)]

Is there any precedent of a bug occuring within those 15 seconds or is that hypothetical?

review: Needs Information

[Sylvain Pineau (sylvain-pineau)]

Not really, I not only want to trap bugs that occur at the beginning of the playback but also those that may happen later. So yes later is difficult to estimate. That's why am looping 3 times the same video before the performing screenshot. I don't want to create a stress test for this one but 15 seconds is not so long.

[Marc Tardif (cr3)]

Agreed, 15 seconds sounds reasonable then. Merging and pushing. Thanks!

review: Approve

[Javier Collado (javier.collado)]

Even if the branch is already merged, I just want to add that I've finally been able to run the test cases and submit the results successfully (using the merged changes in trunk).

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-03-05 14:40:48 +0000
+++ debian/changelog	2012-03-05 16:27:21 +0000
@@ -42,6 +42,7 @@
     plugins/jobs_prompt.py: Added a progress bar showing tests completed and
     total.
 
+<<<<<<< TREE
   [Tiago Salem Herrmann]
   * checkbox_qt/qt_interface.py, qt/frontend/qtfront.cpp,
     qt/frontend/qtfront.h, qt/frontend/treemodel.cpp, qt/frontend/treemodel.h:
@@ -49,6 +50,15 @@
     children nodes.
 
  -- Jeff Lane <[e-mail]>  Fri, 02 Mar 2012 12:13:34 -0500
+=======
+  [Sylvain Pineau]
+  * Updated gst_pipeline_test to add a --fullscreen option for video playback.
+  * Add python-gtk2 dependency, Gst from gi.repository don't work well with 
+    messages (See https://bugzilla.gnome.org/show_bug.cgi?id=631901).
+  * Add a new job to capture screen during fullscreen video playback.
+
+ -- Daniel Manrique <[e-mail]>  Thu, 01 Mar 2012 17:32:15 -0500
+>>>>>>> MERGE-SOURCE
 
 checkbox (0.13.3) precise; urgency=low
 
 
=== modified file 'debian/control'
--- debian/control	2012-02-24 10:05:04 +0000
+++ debian/control	2012-03-05 16:27:21 +0000
@@ -11,7 +11,7 @@
 Section: python
 Architecture: any
 Depends: ${misc:Depends}, ${python:Depends}, debconf, python-libxml2, udev
-Recommends: dpkg (>= 1.13), gstreamer0.10-gconf, lsb-release, perl, pm-utils, python-apport, python-apt, python-dateutil, python-gst0.10
+Recommends: dpkg (>= 1.13), gstreamer0.10-gconf, lsb-release, perl, pm-utils, python-apport, python-apt, python-dateutil, python-gst0.10, python-gtk2
 Suggests: checkbox-cli | checkbox-gtk, bonnie++, bootchart, bzr, cvs, ethtool, flex, fwts, git-core, hdparm, lshw, make, nmap, obexd-client, python-pexpect, smartmontools, sox, stress, wodim
 Description: System testing application 
  This project provides an extensible interface for system testing. The
 
=== modified file 'jobs/graphics.txt.in'
--- jobs/graphics.txt.in	2012-03-05 16:10:58 +0000
+++ jobs/graphics.txt.in	2012-03-05 16:27:21 +0000
@@ -163,3 +163,24 @@
 depends: graphics/screenshot
 command: cat ${CHECKBOX_DATA}/screenshot.jpg
 _description: Attaches the screenshot captured in graphics/screenshot.
+
+plugin: shell
+name: graphics/screenshot_fullscreen_video
+requires: package.name == 'fswebcam'
+command:
+ gst_pipeline_test -t 20 -f "playbin2 uri=file://${CHECKBOX_SHARE}/data/video/Ogg_Theora_Video.ogv" &
+ sleep 15 && camera_test still --highest-device -f ${CHECKBOX_DATA}/screenshot_fullscreen_video.jpg -q 2>&1 | ansi_parser
+_description:
+ PURPOSE:
+     Take a screengrab of the current screen during fullscreen video playback
+ STEPS:
+     1. Start a fullscreen video playback
+     2. Take picture using USB webcam after a few seconds
+ VERIFICATION:
+     1. Review attachment manually later
+
+plugin: attachment
+name: screenshot_fullscreen_video.jpg
+depends: graphics/screenshot_fullscreen_video
+command: cat ${CHECKBOX_DATA}/screenshot_fullscreen_video.jpg
+_description: Attaches the screenshot captured in graphics/screenshot_fullscreen_video.
 
=== modified file 'scripts/gst_pipeline_test'
--- scripts/gst_pipeline_test	2008-10-23 03:34:16 +0000
+++ scripts/gst_pipeline_test	2012-03-05 16:27:21 +0000
@@ -1,37 +1,88 @@
 #!/usr/bin/python
 
+# Note: this code is not based on gi.repository because of a bug that prevents
+# sync-message to be decoded from the bus (current message reports "None" in
+# all cases). See https://bugzilla.gnome.org/show_bug.cgi?id=631901
+
 import sys
-import time
-
+import gtk
+import gobject
 import pygst
 pygst.require("0.10")
-
+import gst
 from optparse import OptionParser
 
 
+class GTK_Main:
+
+    def __init__(self, pipeline, options):
+        self.options = options
+        self.loop = gobject.MainLoop()
+        self.player = gst.parse_launch(pipeline)
+        bus = self.player.get_bus()
+        bus.add_signal_watch()
+        bus.enable_sync_message_emission()
+        bus.connect("message", self.on_message)
+        bus.connect("sync-message::element", self.on_sync_message)
+        self.player.set_state(gst.STATE_PLAYING)
+        gobject.timeout_add(self.options.timeout*1000, self.timeout_cb)
+        self.loop.run()
+
+    def delete_event(self, widget, event, data=None):
+        return False
+
+    def destroy(self, widget, data=None):
+        self.timeout_cb()
+
+    def on_message(self, bus, message):
+        t = message.type
+        if t == gst.MESSAGE_EOS:
+            self.player.seek_simple(gst.FORMAT_TIME, gst.SEEK_FLAG_FLUSH, 0)
+
+    def on_sync_message(self, bus, message):
+        if message.structure is None:
+            return
+        message_name = message.structure.get_name()
+        if message_name == "prepare-xwindow-id":
+            gtk.gdk.threads_enter()
+            gtk.gdk.display_get_default().sync()
+            self.window = gtk.Window()
+            self.window.connect("delete_event", self.delete_event)
+            self.window.connect("destroy", self.destroy)
+            self.movie_window = gtk.DrawingArea()
+            self.window.add(self.movie_window)
+            if self.options.fullscreen:
+                self.window.fullscreen()
+            self.window.show_all()
+            imagesink = message.src
+            imagesink.set_property("force-aspect-ratio", True)
+            imagesink.set_xwindow_id(self.movie_window.window.xid)
+            gtk.gdk.threads_leave()
+
+    def timeout_cb(self):
+        self.player.set_state(gst.STATE_NULL)
+        self.loop.quit()
+
+
 def main(args):
-    import gst
-
     usage = "Usage: %prog [OPTIONS] PIPELINE"
     parser = OptionParser(usage=usage)
     parser.add_option("-t", "--timeout",
         type="int",
-        default=0,
+        default=-1,
         help="Timeout for running the pipeline.")
+    parser.add_option("-f", "--fullscreen",
+        default=False,
+        action="store_true",
+        help="Fullscreen mode (pipeline with video sink only).")
     (options, args) = parser.parse_args(args)
 
     if len(args) != 1:
         parser.error("Must provide a PIPELINE")
 
     pipeline = args[0]
-    element = gst.parse_launch(pipeline)
-    element.set_state(gst.STATE_PLAYING)
-
-    if options.timeout:
-        time.sleep(options.timeout)
-
-    element.set_state(gst.STATE_NULL)
-    return 0
+    gtk.gdk.threads_init()
+    GTK_Main(pipeline, options)
 
 
 if __name__ == "__main__":