Merge lp:~sylvain-pineau/checkbox/show_reports into lp:checkbox

[Sylvain Pineau]

This branch provides additional screens for the gtk/cli and urwid ui to display test results.
Used in conjunction with checkbox-oem, the gtk ui also provides a bug report screen.

These changes come from the "patchy" checkbox maintained by oem-qa and worked well with checkbox-oem.
Once this merge proposal is accepted we could get rid of the oem patches branches for precise.

[Ara Pulido (ara)]

There is some code (about the bug report) that needs to be removed as it won't be accepted FFe

review: Needs Fixing

[lp:~sylvain-pineau/checkbox/show_reports]

1272. By Sylvain Pineau on 2012-02-21

Remove the gtk code of the bug report screen, useless without the corresponding plugin

[Sylvain Pineau (sylvain-pineau)]

I've removed the bug report code making the change only related to the test report for all non qt interfaces

review: Needs Resubmitting

[Marc Tardif (cr3)]

I'm still looking at the code but, in the meanwhile, I'd appreciate if you could report a bug describing the problem this merge request fixes. Then, add the corresponding changelog entry in your branch and feel free to resubmit. Finally, link the bug to your branch. Thanks!

[Marc Tardif (cr3)]

On line 558 of checkbox_gtk/gtk_interface.py, you have the following diff:

- message_dialog.add_button(option, index)
+ button = getattr(Gtk, "STOCK_%s" % option.upper())
+ message_dialog.add_buttons(button, index)

The problem is that the message dialog is also used for prompting the user to restart or recover when running checkbox after the first time. However, there is not STOCK_RESTART nor STOCK_RECOVER attribute in Gtk. If you just revert those two lines to the previous single line, that should work.

review: Needs Fixing

[Marc Tardif (cr3)]

On line 728 of checkbox_urwid/urwid_interface.py, you have the following diff:

- self._collapse_children()
+ #self._collapse_children()

This gives the uneasy feeling that maybe the code was commented out by mistake. I'm not a big fan of commenting out code in general so, while you're making changes, I'd appreciate if you could remove the line completely. Thanks!

[lp:~sylvain-pineau/checkbox/show_reports]

1273. By Sylvain Pineau on 2012-02-21

Updated changelog and fix after reviews

[Sylvain Pineau (sylvain-pineau)]

Thanks for your comment Marc, I've fixed the branch.

review: Needs Resubmitting

[Marc Tardif (cr3)]

First, it seems that your last commit replaced some symlinks by accident:

bzr status -r 1272..
kind changed:
  configs@ (symlink => directory)
  data/websites/PNG_Color_Image_Ubuntu.png@ (symlink => file)
modified:
  checkbox_gtk/gtk_interface.py
  checkbox_urwid/urwid_interface.py
  debian/changelog

Second, I'm not seeing the show_report method in the user interface called anywhere. And, when I run the GTK interface, the view report button still shows the old report. Is the purpose that this code will only be called by checkbox-oem rather than checkbox?

review: Needs Fixing

[lp:~sylvain-pineau/checkbox/show_reports]

1274. By Sylvain Pineau on 2012-02-22

Update plugins to take advantage of the report screen

[Sylvain Pineau (sylvain-pineau)]

1) Even after rebranching the code, i don't see the symlink errors you mentioned.
2) It was an error, the report code is intended to be rendered by checkbox, not only checkbox-oem. I've updated the plugins to enable it.

review: Needs Resubmitting

[lp:~sylvain-pineau/checkbox/show_reports]

1275. By Sylvain Pineau on 2012-02-22

Fix missing text parameter and use NotImplementedError to raise exception in show_report

[Marc Tardif (cr3)]

The first problem was my mistake, sorry about that. As for the second problem, I now see the report. However, do you think we should remove the "View report" link from the final screen? Otherwise, it seems strange to have two ways to view essentially the same information.

review: Needs Information

[lp:~sylvain-pineau/checkbox/show_reports]

1276. By Sylvain Pineau on 2012-02-22

Remove the gtk ui implementation to just keep cli/urwid and avoid duplication with the submission.xml link

[Sylvain Pineau (sylvain-pineau)]

The scope of the proposal is now limited to the cli/urwid interface, given that the gtk interface allows the tester to open the submission.xml to review the results.

review: Needs Resubmitting

[Marc Tardif (cr3)]

1. I unliked bug #937764 from this merge request which only seems to relate to bug #937657.

2. I would appreciate if you could rephrase bug #937657 as a problem rather than a feature request.

3. I updated the changelog entry to be less intimidating: Display results report in non-graphical interfaces.

4. I changed checking for the show_report attribute in plugins/report_prompt.py to catching the NotImplementError silently in plugins/launchpad_report.py instead.

Finally, I merged and pushed the rest of your changes.

review: Approve

=== modified file 'checkbox_cli/cli_interface.py'
--- checkbox_cli/cli_interface.py	2012-02-09 16:03:54 +0000
+++ checkbox_cli/cli_interface.py	2012-02-22 17:22:19 +0000
@@ -160,6 +160,94 @@
         self.options.append(option)
 
 
+class CLIReportDialog(CLIDialog):
+    """
+    Display test results
+    """
+    STATUS = {'pass': '{0}',
+              'fail': '{0}'}
+
+    def __init__(self, text, results):
+        super(CLIReportDialog, self).__init__(text)
+        self.results = results
+
+    def run(self):
+        """
+        Show root of the tree
+        and provide the ability to further display subtress
+        """
+        root = self.results
+        title = self.text
+        self._display(title, root)
+
+    def _is_suite(self, root):
+        """
+        Return True if root contains a suite
+        that is, a job containing other jobs
+        """
+        return all(issubclass(type(value), dict)
+                   for value in root.itervalues())
+
+    def _display(self, title, root):
+        """
+        Display dialog until user decides to exit
+        (recursively for subtrees)
+        """
+        while True:
+            self.put_newline()
+            self.put_newline()
+            self.put_line(title)
+            self.put_newline()
+
+            keys = []
+            options = []
+            def add_option(option, key=None):
+                """
+                Add option to list
+                and generate automatic key value
+                if not provided
+                """
+                if key is None:
+                    key = string.lowercase[len(keys)]
+                keys.append(key)
+                options.append(option)
+
+            for job_name, job_data in sorted(root.iteritems()):
+                if self._is_suite(job_data):
+                    add_option(job_name)
+                    self.put_line('{key}: {option}'
+                                  .format(key=keys[-1],
+                                          option=options[-1]))
+                else:
+                    job_status = job_data.get('status')
+                    status_string = (self.STATUS.get(job_status, '{0}')
+                                     .format(job_status))
+                    self.put_line('   {name} [{status}]'
+                                  .format(name=job_name,
+                                          status=status_string))
+
+            add_option(_("Space when finished"), " ")
+            self.put_line('{key}: {option}'
+                          .format(key=keys[-1],
+                                  option=options[-1]))
+
+            response = self.get(_("Please choose (%s): ") % ("/".join(keys)))
+
+            if response != ' ':
+                try:
+                    selected_option = options[keys.index(response)]
+                except ValueError:
+                    # Display again menu
+                    continue
+
+                # Display new menu with the contents of the selected option
+                self._display(selected_option, root[selected_option])
+            else:
+                # Exit from this menu display
+                # (display again parent menu or exit)
+                break
+
+
 class CLITextDialog(CLIDialog):
 
     limit = 255
@@ -271,7 +359,6 @@
 
     def show_tree(self, text, options={}, default={}):
         keys = sorted(options.keys())
-        values = [options[k] for k in keys]
 
         dialog = CLIChoiceDialog(text)
         for option in keys:
@@ -314,6 +401,15 @@
 
         return results
 
+
+    def show_report(self, text, results):
+        """
+        Show test case results in a tree hierarchy
+        """
+        dialog = CLIReportDialog(text, results)
+        dialog.run()
+
+
     def show_test(self, test, runner):
         options = list([ANSWER_TO_OPTION[a] for a in ALL_ANSWERS])
         if "command" in test:
 
=== modified file 'checkbox_gtk/gtk_interface.py'
--- checkbox_gtk/gtk_interface.py	2012-02-09 16:03:54 +0000
+++ checkbox_gtk/gtk_interface.py	2012-02-22 17:22:19 +0000
@@ -116,7 +116,7 @@
         for radio_button, value in map.items():
             if self._get_widget(radio_button).get_active():
                 return value
-        raise Exception, "Failed to map radio_button."
+        raise Exception("Failed to map radio_button.")
 
     def _get_label(self, name):
         widget = self._get_widget(name)
 
=== modified file 'checkbox_urwid/urwid_interface.py'
--- checkbox_urwid/urwid_interface.py	2012-02-09 16:03:54 +0000
+++ checkbox_urwid/urwid_interface.py	2012-02-22 17:22:19 +0000
@@ -19,6 +19,7 @@
 import urwid
 
 import re, string
+from operator import itemgetter
 from gettext import gettext as _
 
 from checkbox.user_interface import (UserInterface, NEXT, PREV,
@@ -37,7 +38,12 @@
                ('button focused', 'white', 'dark blue'),
                ('highlight', 'black', 'dark cyan'),
                ('highlight focused', 'white', 'dark blue'),
+               ('fail', 'light red', 'dark cyan'),
+               ('pass', 'light green', 'dark cyan'),
+               ('result', 'light gray', 'dark cyan'),
                )
+    PALETTE_MEMBERS = set(color_spec[0]
+                          for color_spec in PALETTE)
     header = None
     footer = None
 
@@ -368,12 +374,12 @@
         """
         Create a tree node and all its children
         """
-        widget = TreeNodeWidget(name, parent)
+        widget = SelectableTreeNodeWidget(name, parent)
         urwid.signals.connect_signal(widget, 'change',
                                      widget.changed_cb, self.walker)
 
         if isinstance(data, dict):
-            items = sorted(data.iteritems(), key=lambda item: item[0])
+            items = sorted(data.iteritems(), key=itemgetter(0))
             for children_name, children_data in items:
                 child_widget = self.create_tree(children_name, children_data, widget)
                 widget.append(child_widget)
@@ -402,14 +408,15 @@
 
         # Show tree
         self.option_widgets = []
-        items = sorted(self.options.iteritems(), key=lambda item: item[0])
+        items = sorted(self.options.iteritems(),
+                       key=itemgetter(0))
         for name, data in items:
             widget = self.create_tree(name, data)
             self.option_widgets.append(widget)
             self.walker.append(widget)
 
         self._set_default([node for node in self.walker
-                           if isinstance(node, TreeNodeWidget)],
+                           if isinstance(node, SelectableTreeNodeWidget)],
                           self.default)
 
         # Show buttons
@@ -422,9 +429,131 @@
         self.walker.append(buttons_box)
 
 
+class ReportDialog(ChoiceDialog):
+    """
+    Display test results dialog
+    """
+    footer = urwid.AttrMap(urwid.Columns((urwid.Text('Arrow keys/Page Up/Page Down: Move'),
+                                          urwid.Text(''),
+                                          urwid.Text('+/-/Enter/Space: Expand/Collapse'))),
+                           'footer')
+
+    def __init__(self, text, results):
+        Dialog.__init__(self, text)
+        self.results = results
+
+
+    def _get_tree_node(self, node):
+        """
+        Get tree node even if a column is wrapping it
+        """
+        if issubclass(type(node), TreeNodeWidget):
+            return node
+        elif issubclass(type(node), urwid.Columns):
+            for widget in child.widget_list:
+                if issubclass(type(widget), TreeNodeWidget):
+                    return widget
+        return node
+
+
+    def expand_all_clicked_cb(self, button):
+        """
+        Expand all elements in the tree to see results
+        """
+        for tree_node in [self._get_tree_node(node)
+                          for node in self.root_nodes]:
+            tree_node.expand(expand_all=True)
+
+
+    def collapse_all_clicked_cb(self, button):
+        """
+        Collapse all elements in the tree to see results
+        """
+        for tree_node in [self._get_tree_node(node)
+                          for node in self.root_nodes]:
+            tree_node.collapse(collapse_all=True)
+
+
+    def next_button_clicked_cb(self, button):
+        """
+        Set direction, response and exit
+        """
+        self.direction = NEXT
+        raise urwid.ExitMainLoop
+
+
+    def previous_button_clicked_cb(self, button):
+        """
+        Set direction, response and exit
+        """
+        self.direction = PREV
+        raise urwid.ExitMainLoop
+
+
+    def create_tree(self, name, data, parent=None):
+        """
+        Create a tree node and all its children
+        """
+        widget = TreeNodeWidget(name, parent)
+        urwid.signals.connect_signal(widget, 'change',
+                                     widget.changed_cb, self.walker)
+
+        items = sorted(data.iteritems(), key=itemgetter(0))
+        for child_name, child_data in items:
+            is_suite = all(issubclass(type(value), dict)
+                           for value in child_data.itervalues())
+
+            if is_suite:
+                child_widget = self.create_tree(child_name,
+                                                child_data,
+                                                widget)
+            else:
+                result=child_data['status']
+
+                # Use color specification for result
+                # if found or default one
+                attr = (result
+                        if result in self.PALETTE_MEMBERS
+                        else 'result')
+
+                child_widget = urwid.Columns(
+                    (TreeNodeWidget(child_name, widget),
+                     urwid.AttrMap(urwid.Text((attr, result)),
+                                   'highlight', 'highlight focused')))
+            widget.append(child_widget)
+
+        return widget
+
+
+    def show(self):
+        """
+        Display dialog text, options tree and buttons
+        """
+        # Show text
+        Dialog.show(self)
+
+        # Show tree
+        items = sorted(self.results.iteritems(),
+                       key=itemgetter(0))
+        for name, data in items:
+            widget = self.create_tree(name, data)
+            self.walker.append(widget)
+
+        self.root_nodes = [node for node in self.walker]
+
+        # Show buttons
+        labels = ((_('Expand All'), self.expand_all_clicked_cb),
+                  (_('Collapse All'), self.collapse_all_clicked_cb),
+                  (_('Previous'), self.previous_button_clicked_cb),
+                  (_('Next'), self.next_button_clicked_cb))
+        buttons_box = self.create_buttons(labels)
+        self.walker.append(urwid.Divider())
+        self.walker.append(buttons_box)
+
+
 class TreeNodeWidget(urwid.WidgetWrap):
     """
-    Implementation of a node in a tree that can be selected/deselected
+    Implementation of a node in a tree that can be expanded/unexpanded
     """
     signals = ['change']
 
@@ -436,17 +565,45 @@
 
         self.expanded = False
 
-        # Use a checkbox as internal representation of the widget
-        self.checkbox = urwid.CheckBox(self._get_label())
-        w = urwid.AttrMap(self.checkbox, 'highlight', 'highlight focused')
+        w = self._get_widget()
         super(TreeNodeWidget, self).__init__(w)
 
 
+    def _get_widget(self):
+        """
+        Create widget that is wrapped by this class
+        """
+        self.widget = urwid.Text(self._get_label())
+        w = urwid.AttrMap(self.widget, 'highlight', 'highlight focused')
+        return w
+
+
+    def _update_label(self):
+        """
+        Update text label
+        """
+        self.widget.set_text(self._get_label())
+
+
+    def _get_node(self, child):
+        """
+        Get TreeNode directly without traversing Columns
+        """
+        if issubclass(type(child), TreeNodeWidget):
+            return child
+        elif issubclass(type(child), urwid.Columns):
+            for widget in child.widget_list:
+                if issubclass(type(widget), TreeNodeWidget):
+                    return widget
+        return child
+
+
     def __iter__(self):
         """
         Iterate over children nodes
         """
-        return iter(self.children)
+        return iter([self._get_node(child)
+                     for child in self.children])
 
 
     def __len__(self):
@@ -476,69 +633,17 @@
         return True
 
 
-    @property
-    def state(self):
-        """
-        Get state from checkbox widget
-        """
-        return self.checkbox.get_state()
-
-
-    @state.setter
-    def state(self, value):
-        """
-        Set state to checkbox widget
-        """
-        self.checkbox.set_state(value)
-
-
-    def set_ancestors_state(self, new_state):
-        """
-        Set the state of all ancestors consistently
-        """
-        # If child is set, then all ancestors must be set
-        if new_state:
-            parent = self.parent
-            while parent:
-                parent.state = new_state
-                parent = parent.parent
-        # If child is not set, then all ancestors mustn't be set
-        # unless another child of the ancestor is set
-        else:
-            parent = self.parent
-            while parent:
-                if any((child.state
-                        for child in parent)):
-                    break
-                parent.state = new_state
-                parent = parent.parent
-
-
-    def set_children_state(self, new_state):
-        """
-        Set the state of all children recursively
-        """
-        self.state = new_state
-        for child in self:
-            child.set_children_state(new_state)
-
-
     def keypress(self, size, key):
         """
-        Use key events to select checkbox and expand tree hierarchy
+        Use key events to expand/collapse tree hierarchy
         """
-
-        if key == ' ':
-            new_state = not self.state
-            self.state = new_state
-            self.set_children_state(new_state)
-            self.set_ancestors_state(new_state)
-            return None
-        elif self.children:
-            if key in ('+', 'enter') and self.expanded == False:
+        if self.children:
+            if (key in ('+', 'enter', ' ')
+                and self.expanded == False):
                 urwid.signals.emit_signal(self, 'change')
                 return None
-            elif key in ('-', 'enter') and self.expanded == True:
+            elif (key in ('-', 'enter', ' ')
+                  and self.expanded == True):
                 urwid.signals.emit_signal(self, 'change')
                 return None
 
@@ -547,16 +652,10 @@
 
     def mouse_event(self, size, event, button, col, row, focus):
         """
-        Use mouse events to select checkbox and expand tree hierarchy
+        Use mouse events to expand/collapse tree hierarchy
         """
-        # Left click event
-        if button == 1:
-            new_state = not self.state
-            self.state = new_state
-            self.set_children_state(new_state)
-            self.set_ancestors_state(new_state)
         # Ignore button release event
-        elif button == 0:
+        if button == 0:
             pass
         else:
             urwid.signals.emit_signal(self, 'change')
@@ -581,11 +680,15 @@
         return label
 
 
-    def _update_label(self):
-        """
-        Update text label
-        """
-        self.checkbox.set_label(self._get_label())
+    def collapse(self, collapse_all=False):
+        """
+        Collapse node
+        """
+        if self.expanded == True:
+            urwid.signals.emit_signal(self, 'change')
+
+        if collapse_all:
+            self._collapse_children()
 
 
     def _collapse_children(self):
@@ -593,12 +696,24 @@
         Collapse all children
         """
         for child in self:
+            child._collapse_children()
             if child.expanded:
-                child._collapse_children()
                 child.expanded = False
                 child._update_label()
 
 
+    def expand(self, expand_all=False):
+        """
+        Expand node
+        """
+        if self.expanded == False:
+            urwid.signals.emit_signal(self, 'change')
+
+            if expand_all:
+                for child in self:
+                    child.expand(expand_all)
+
+
     def changed_cb(self, walker):
         """
         Handle node expansion in the tree
@@ -610,18 +725,134 @@
             del_end_position = (del_start_position +
                                 len(self) - 1)
             del walker[del_start_position:del_end_position]
-            self._collapse_children()
             self.expanded = False
         else:
             insert_position = position + 1
 
             # Append widgets to the list
-            walker[insert_position:insert_position] = self.children
+            subtree = list(self._get_subtree())
+            walker[insert_position:insert_position] = subtree
             self.expanded = True
 
         self._update_label()
 
 
+    def _get_subtree(self):
+        """
+        Return subtree with expanded children
+        """
+        for child in self.children:
+            yield child
+
+            child_node = self._get_node(child)
+            if child_node.expanded:
+                for descendant in child._get_subtree():
+                    yield descendant
+
+
+class SelectableTreeNodeWidget(TreeNodeWidget):
+    """
+    Implementation of a node in a tree that can be selected/deselected
+    """
+    def __init__(self, name, parent=None):
+        super(SelectableTreeNodeWidget, self).__init__(name, parent)
+
+
+    def _get_widget(self):
+        """
+        Create widget that is wrapped by this class
+        """
+        # Use a checkbox to preserve widget selection stat
+        self.widget = urwid.CheckBox(self._get_label())
+        w = urwid.AttrMap(self.widget, 'highlight', 'highlight focused')
+        return w
+
+
+    def _update_label(self):
+        """
+        Update text label
+        """
+        self.widget.set_label(self._get_label())
+
+
+    @property
+    def state(self):
+        """
+        Get state from checkbox widget
+        """
+        return self.widget.get_state()
+
+
+    @state.setter
+    def state(self, value):
+        """
+        Set state to checkbox widget
+        """
+        self.widget.set_state(value)
+
+
+    def set_ancestors_state(self, new_state):
+        """
+        Set the state of all ancestors consistently
+        """
+        # If child is set, then all ancestors must be set
+        if new_state:
+            parent = self.parent
+            while parent:
+                parent.state = new_state
+                parent = parent.parent
+        # If child is not set, then all ancestors mustn't be set
+        # unless another child of the ancestor is set
+        else:
+            parent = self.parent
+            while parent:
+                if any((child.state
+                        for child in parent)):
+                    break
+                parent.state = new_state
+                parent = parent.parent
+
+
+    def set_children_state(self, new_state):
+        """
+        Set the state of all children recursively
+        """
+        self.state = new_state
+        for child in self:
+            child.set_children_state(new_state)
+
+
+    def keypress(self, size, key):
+        """
+        Use key events to select checkbox and expand tree hierarchy
+        """
+
+        if key == ' ':
+            new_state = not self.state
+            self.state = new_state
+            self.set_children_state(new_state)
+            self.set_ancestors_state(new_state)
+            return None
+
+        return super(SelectableTreeNodeWidget, self).keypress(size, key)
+
+
+    def mouse_event(self, size, event, button, col, row, focus):
+        """
+        Use mouse events to select checkbox and expand tree hierarchy
+        """
+        # Left click event
+        if button == 1:
+            new_state = not self.state
+            self.state = new_state
+            self.set_children_state(new_state)
+            self.set_ancestors_state(new_state)
+            return True
+
+        return (super(SelectableTreeNodeWidget, self)
+                .mouse_event(size, event, button, col, row, focus))
+
+
 class ProgressDialog(Dialog):
     """
     Show progress through a bar
@@ -753,6 +984,14 @@
         return dialog.response
 
 
+    def show_report(self, text, results):
+        """
+        Show test case results in a tree hierarchy
+        """
+        dialog = ReportDialog(text, results).run()
+        self.direction = dialog.direction
+
+
     def show_test(self, test, runner):
         """
         Show test description, radio buttons to set result
@@ -792,7 +1031,7 @@
         test['data'] = dialog.input
         test['status'] = ANSWER_TO_STATUS[answer]
         self.direction = dialog.direction
-        return self.response
+        return dialog.response
 
 
     def show_info(self, text, options=[], default=None):
 
=== modified file 'debian/changelog'
--- debian/changelog	2012-02-20 08:22:59 +0000
+++ debian/changelog	2012-02-22 17:22:19 +0000
@@ -5,6 +5,7 @@
   
   [Sylvain Pineau]
   * Fix depends fields in info and suspend test suites (LP: #934051) 
+  * Display results report before upload (LP: #937657)
 
   [Brendan Donegan]
   * Typo in command for for miscellanea/virtualization-check (LP: #934243)
 
=== modified file 'plugins/launchpad_report.py'
--- plugins/launchpad_report.py	2012-02-07 20:39:15 +0000
+++ plugins/launchpad_report.py	2012-02-22 17:22:19 +0000
@@ -66,6 +66,8 @@
              ("report-package", self.report_package),
              ("report-uname", self.report_uname),
              ("report-system_id", self.report_system_id),
+             ("report-suites", self.report_suites),
+             ("report-review", self.report_review),             
              ("report-tests", self.report_tests)]:
             self._manager.reactor.call_on(rt, rh)
 
@@ -136,6 +138,7 @@
         self._report["summary"]["system_id"] = system_id
 
     def report_tests(self, tests):
+        self.tests = tests
         for test in tests:
             question = {
                 "name": test["name"],
@@ -167,5 +170,50 @@
 
         self._manager.reactor.fire("launchpad-report", self.filename)
 
+    def report_review(self, interface):
+        """
+        Show test report in the interface
+        """
+        report = {}
+
+        def add_job(job):
+            is_suite = 'type' in job and job['type'] == 'suite'
+            if 'suite' in job:
+                suite_name = job['suite']
+                parent_node = add_job(self.suites[suite_name])
+
+                if is_suite:
+                    if job['description'] in parent_node:
+                        return parent_node[job['description']]
+
+                    node = {}
+                    parent_node[job['description']] = node
+                    return node
+                parent_node[job['name']] = job
+            else:
+                if is_suite:
+                    field = 'description'
+                else:
+                    field = 'name'
+
+                if job[field] in report:
+                    return report[job[field]]
+
+                node = {}
+                report[job[field]] = node
+                return node
+
+        for test in self.tests:
+            add_job(test)
+
+        interface.show_report("Test case results report", report)
+
+    def report_suites(self, suites):
+        """
+        Get tests results and store it
+        to display them later
+        """
+        self.suites = dict([(suite['name'], suite) for suite in suites])
+
 
 factory = LaunchpadReport
 
=== modified file 'plugins/report_prompt.py'
--- plugins/report_prompt.py	2011-09-08 14:52:33 +0000
+++ plugins/report_prompt.py	2012-02-22 17:22:19 +0000
@@ -40,6 +40,8 @@
                 self._manager.reactor.fire, "report")
 
         self._manager.reactor.cancel_call(event_id)
+        if hasattr(interface, 'show_report'):
+            self._manager.reactor.fire("report-review", interface)
 
 
 factory = ReportPrompt