Code review comment for lp:~sylvain-pineau/checkbox/gui_export_xlsx_with_all_options

+1

On Wed, May 21, 2014 at 3:25 PM, Sylvain Pineau <
<email address hidden>> wrote:

> Sylvain Pineau has proposed merging
> lp:~sylvain-pineau/checkbox/gui_export_xlsx_with_all_options into
> lp:checkbox.
>
> Requested reviews:
> Checkbox Developers (checkbox-dev)
>
> For more details, see:
>
> https://code.launchpad.net/~sylvain-pineau/checkbox/gui_export_xlsx_with_all_options/+merge/220453
>
> Enable all the options supported by the xlsx exporter in checkbox-gui to
> get the same kind of report that checkbox-certification/oem provided.
> --
>
> https://code.launchpad.net/~sylvain-pineau/checkbox/gui_export_xlsx_with_all_options/+merge/220453
> Your team Checkbox Developers is requested to review the proposed merge of
> lp:~sylvain-pineau/checkbox/gui_export_xlsx_with_all_options into
> lp:checkbox.
>
> === modified file 'checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml'
> --- checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml 2014-05-16
> 10:10:18 +0000
> +++ checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml 2014-05-21
> 13:24:21 +0000
> @@ -147,7 +147,7 @@
> else if (reportTypeSelect.selectedIndex == 1) {
> var path = guiEngine.GetSaveFileName('submission.xlsx',
> i18n.tr("XLSX files (*.xlsx)"))
> - success = guiEngine.GuiExportSessionToFileAsXLSX(path,
> []);
> + success = guiEngine.GuiExportSessionToFileAsXLSX(path,
> ["with-sys-info", "with-summary", "with-job-description",
> "with-text-attachments"]);
> }
>
> if (success) {
>
>
>