Merge lp:~sylvain-pineau/checkbox/fixes_required_for_cdts into lp:checkbox

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 4390
Merged at revision: 4393
Proposed branch: lp:~sylvain-pineau/checkbox/fixes_required_for_cdts
Merge into: lp:checkbox
Diff against target: 77 lines (+24/-6)
4 files modified
checkbox-ng/launchers/checkbox-cli (+4/-2)
checkbox-touch/components/WebViewer.qml (+15/-1)
checkbox-touch/py/checkbox_touch.py (+4/-2)
plainbox/plainbox/impl/exporter/tar.py (+1/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/fixes_required_for_cdts
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+296419@code.launchpad.net

Description of the change

Collection of small fixes/enhancements to get cdts to work with a 2016 checkbox

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

+1, this is what you showed at the standup a bit ago right?

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Indeed, the extra menu was running from this branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'checkbox-ng/launchers/checkbox-cli'
--- checkbox-ng/launchers/checkbox-cli 2016-05-30 21:46:04 +0000
+++ checkbox-ng/launchers/checkbox-cli 2016-06-03 10:18:52 +0000
@@ -697,8 +697,10 @@
697 self.launcher.transports['{}_file'.format(exporter)] = {697 self.launcher.transports['{}_file'.format(exporter)] = {
698 'type': 'file',698 'type': 'file',
699 'path': path}699 'path': path}
700 self.launcher.exporters[exporter] = {700 if exporter not in self.launcher.exporters:
701 'unit': '2013.com.canonical.plainbox::{}'.format(exporter)}701 self.launcher.exporters[exporter] = {
702 'unit': '2013.com.canonical.plainbox::{}'.format(
703 exporter)}
702 self.launcher.reports['2_{}_file'.format(exporter)] = {704 self.launcher.reports['2_{}_file'.format(exporter)] = {
703 'transport': '{}_file'.format(exporter),705 'transport': '{}_file'.format(exporter),
704 'exporter': '{}'.format(exporter),706 'exporter': '{}'.format(exporter),
705707
=== modified file 'checkbox-touch/components/WebViewer.qml'
--- checkbox-touch/components/WebViewer.qml 2015-07-16 13:58:31 +0000
+++ checkbox-touch/components/WebViewer.qml 2016-06-03 10:18:52 +0000
@@ -35,10 +35,24 @@
35 id: wv35 id: wv
36 anchors.fill: parent36 anchors.fill: parent
37 url: ""37 url: ""
38 contextualActions: ActionList {
39 Action {
40 text: i18n.tr("Open in a browser")
41 onTriggered: Qt.openUrlExternally(wv.url)
42 }
43 Action {
44 text: i18n.tr("Go back one page")
45 onTriggered: wv.goBack()
46 }
47 Action {
48 text: i18n.tr("Reload current page")
49 onTriggered: wv.reload()
50 }
51 }
38 }52 }
3953
40 onUriChanged: {54 onUriChanged: {
41 wv.url = uri;55 wv.url = uri;
42 wv.reload();56 wv.reload();
43 }57 }
44}
45\ No newline at end of file58\ No newline at end of file
59}
4660
=== modified file 'checkbox-touch/py/checkbox_touch.py'
--- checkbox-touch/py/checkbox_touch.py 2016-05-30 22:07:02 +0000
+++ checkbox-touch/py/checkbox_touch.py 2016-06-03 10:18:52 +0000
@@ -631,8 +631,10 @@
631 self.launcher.transports['{}_file'.format(exporter)] = {631 self.launcher.transports['{}_file'.format(exporter)] = {
632 'type': 'file',632 'type': 'file',
633 'path': path}633 'path': path}
634 self.launcher.exporters[exporter] = {634 if exporter not in self.launcher.exporters:
635 'unit': '2013.com.canonical.plainbox::{}'.format(exporter)}635 self.launcher.exporters[exporter] = {
636 'unit': '2013.com.canonical.plainbox::{}'.format(
637 exporter)}
636 self.launcher.reports['2_{}_file'.format(exporter)] = {638 self.launcher.reports['2_{}_file'.format(exporter)] = {
637 'transport': '{}_file'.format(exporter),639 'transport': '{}_file'.format(exporter),
638 'exporter': '{}'.format(exporter)640 'exporter': '{}'.format(exporter)
639641
=== modified file 'plainbox/plainbox/impl/exporter/tar.py'
--- plainbox/plainbox/impl/exporter/tar.py 2016-05-18 08:38:44 +0000
+++ plainbox/plainbox/impl/exporter/tar.py 2016-06-03 10:18:52 +0000
@@ -95,7 +95,7 @@
95 continue95 continue
96 for stdstream in ('stdout', 'stderr'):96 for stdstream in ('stdout', 'stderr'):
97 filename = recordname.replace('record.gz', stdstream)97 filename = recordname.replace('record.gz', stdstream)
98 if os.path.getsize(filename):98 if os.path.exists(filename) and os.path.getsize(filename):
99 arcname = os.path.basename(filename)99 arcname = os.path.basename(filename)
100 if stdstream == 'stdout':100 if stdstream == 'stdout':
101 arcname = os.path.splitext(arcname)[0]101 arcname = os.path.splitext(arcname)[0]

Subscribers

People subscribed via source and target branches