Merge lp:~sylvain-pineau/checkbox/fixes_required_for_cdts into lp:checkbox

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 4390
Merged at revision: 4393
Proposed branch: lp:~sylvain-pineau/checkbox/fixes_required_for_cdts
Merge into: lp:checkbox
Diff against target: 77 lines (+24/-6)
4 files modified
checkbox-ng/launchers/checkbox-cli (+4/-2)
checkbox-touch/components/WebViewer.qml (+15/-1)
checkbox-touch/py/checkbox_touch.py (+4/-2)
plainbox/plainbox/impl/exporter/tar.py (+1/-1)
To merge this branch: bzr merge lp:~sylvain-pineau/checkbox/fixes_required_for_cdts
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+296419@code.launchpad.net

Description of the change

Collection of small fixes/enhancements to get cdts to work with a 2016 checkbox

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

+1, this is what you showed at the standup a bit ago right?

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Indeed, the extra menu was running from this branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-ng/launchers/checkbox-cli'
2--- checkbox-ng/launchers/checkbox-cli 2016-05-30 21:46:04 +0000
3+++ checkbox-ng/launchers/checkbox-cli 2016-06-03 10:18:52 +0000
4@@ -697,8 +697,10 @@
5 self.launcher.transports['{}_file'.format(exporter)] = {
6 'type': 'file',
7 'path': path}
8- self.launcher.exporters[exporter] = {
9- 'unit': '2013.com.canonical.plainbox::{}'.format(exporter)}
10+ if exporter not in self.launcher.exporters:
11+ self.launcher.exporters[exporter] = {
12+ 'unit': '2013.com.canonical.plainbox::{}'.format(
13+ exporter)}
14 self.launcher.reports['2_{}_file'.format(exporter)] = {
15 'transport': '{}_file'.format(exporter),
16 'exporter': '{}'.format(exporter),
17
18=== modified file 'checkbox-touch/components/WebViewer.qml'
19--- checkbox-touch/components/WebViewer.qml 2015-07-16 13:58:31 +0000
20+++ checkbox-touch/components/WebViewer.qml 2016-06-03 10:18:52 +0000
21@@ -35,10 +35,24 @@
22 id: wv
23 anchors.fill: parent
24 url: ""
25+ contextualActions: ActionList {
26+ Action {
27+ text: i18n.tr("Open in a browser")
28+ onTriggered: Qt.openUrlExternally(wv.url)
29+ }
30+ Action {
31+ text: i18n.tr("Go back one page")
32+ onTriggered: wv.goBack()
33+ }
34+ Action {
35+ text: i18n.tr("Reload current page")
36+ onTriggered: wv.reload()
37+ }
38+ }
39 }
40
41 onUriChanged: {
42 wv.url = uri;
43 wv.reload();
44 }
45-}
46\ No newline at end of file
47+}
48
49=== modified file 'checkbox-touch/py/checkbox_touch.py'
50--- checkbox-touch/py/checkbox_touch.py 2016-05-30 22:07:02 +0000
51+++ checkbox-touch/py/checkbox_touch.py 2016-06-03 10:18:52 +0000
52@@ -631,8 +631,10 @@
53 self.launcher.transports['{}_file'.format(exporter)] = {
54 'type': 'file',
55 'path': path}
56- self.launcher.exporters[exporter] = {
57- 'unit': '2013.com.canonical.plainbox::{}'.format(exporter)}
58+ if exporter not in self.launcher.exporters:
59+ self.launcher.exporters[exporter] = {
60+ 'unit': '2013.com.canonical.plainbox::{}'.format(
61+ exporter)}
62 self.launcher.reports['2_{}_file'.format(exporter)] = {
63 'transport': '{}_file'.format(exporter),
64 'exporter': '{}'.format(exporter)
65
66=== modified file 'plainbox/plainbox/impl/exporter/tar.py'
67--- plainbox/plainbox/impl/exporter/tar.py 2016-05-18 08:38:44 +0000
68+++ plainbox/plainbox/impl/exporter/tar.py 2016-06-03 10:18:52 +0000
69@@ -95,7 +95,7 @@
70 continue
71 for stdstream in ('stdout', 'stderr'):
72 filename = recordname.replace('record.gz', stdstream)
73- if os.path.getsize(filename):
74+ if os.path.exists(filename) and os.path.getsize(filename):
75 arcname = os.path.basename(filename)
76 if stdstream == 'stdout':
77 arcname = os.path.splitext(arcname)[0]

Subscribers

People subscribed via source and target branches