Code review comment for lp:~sylvain-pineau/checkbox/fix-1477423

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I kind of don't like one thing (but I suspect qt compensates for that). The timer runs regardless of any updates being needed or not. I would prefer to only start the timer (in one-shot more) when we know there is something to do.

Oh, and let's file those upstream bugs, this should not be needed.

review: Approve

« Back to merge proposal