Code review comment for lp:~sylvain-pineau/checkbox/eMMC_as_DISK

Revision history for this message
Paul Larson (pwlars) wrote :

It's probably worth updating the copyright in the other files you changed, since they changed and you're updating others.

I'm curious of the test results on real hardware too, and does it (or should it) make a difference whether you are running from a booted usb stick or from an installation to the emmc? Are there some disk tests that we don't want to run for good reason? In the past, I think a lot of testing on things like panda have intentionally avoided disk tests on emmc because they are so slow. Something that took only a few minutes on x86 would suddenly take hours and just wind up hitting the timeout.

review: Needs Information

« Back to merge proposal