Code review comment for lp:~sylvain-pineau/checkbox/checkbox-ng-sa

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Hey. Thanks for sending this. I made several small comments below. I like the direction this is going but I'd like to overall streamline the code. I realize we cherry picked functions from various locations but now we have a chance to simplify and unify this so that it is easier to understand.

I would also like to know exactly which features we aim to support here (in other words, this is not a launcher interpreter). It would be good if we could write this down in the docstring of the module.

« Back to merge proposal