Merge lp:~sylvain-pineau/checkbox/937715_submit_disabled_at_startup into lp:checkbox
Proposed by
Sylvain Pineau
Status: | Merged |
---|---|
Merged at revision: | 1353 |
Proposed branch: | lp:~sylvain-pineau/checkbox/937715_submit_disabled_at_startup |
Merge into: | lp:checkbox |
Diff against target: |
33 lines (+6/-0) 2 files modified
debian/changelog (+2/-0) qt/frontend/qtfront.cpp (+4/-0) |
To merge this branch: | bzr merge lp:~sylvain-pineau/checkbox/937715_submit_disabled_at_startup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeff Lane | Approve | ||
Review via email: mp+100803@code.launchpad.net |
Description of the change
This MR tries to solve a new feature only available with the Qt UI. The ability to switch from one tab to another is quite complex to handle with checkbox events. So I prefer to disable the submission buttons until the end of the test run.
To post a comment you must log in.
Sylvain,
The behavior after the patch looks reasonable to me.
But I still see the warning text in the content of results tab.
------------
Warning: Not all tests have been run yet.
You can send the results now, but the submission won't make it to Ubuntu Friendly.
------------
After the buttons being disabled, user has no way to submit the result before all tests are finished.
For now, to prevent confusing users, should we change the texts to something like "You have to finish all the tests before you can submit the result"?