Code review comment for lp:~sylvain-pineau/checkbox/937715_submit_disabled_at_startup
Revision history for this message
| TienFu Chen (ctf) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Sylvain,
The behavior after the patch looks reasonable to me.
But I still see the warning text in the content of results tab.
------------
Warning: Not all tests have been run yet.
You can send the results now, but the submission won't make it to Ubuntu Friendly.
------------
After the buttons being disabled, user has no way to submit the result before all tests are finished.
For now, to prevent confusing users, should we change the texts to something like "You have to finish all the tests before you can submit the result"?