Merge ~sylvain-pineau/checkbox-support:fake_usb.ids_unittest into checkbox-support:master

[Sylvain Pineau]

a simple fix to run the unit tests using a tempfile instead of real usb.ids

[Maciej Kisielewski (kissiel)]

The temporary file is not needed. What was missing, was the patch for isfile calls. See here:
https://code.launchpad.net/~kissiel/checkbox-support/+git/checkbox-support/+merge/392299

Unmerged commits

fedb50d... by Sylvain Pineau on 2020-10-15

parsers:tests:sysfs_usb: Use a amedTemporaryFile to fake usb.ids

diff --git a/checkbox_support/parsers/tests/test_sysfs_usb.py b/checkbox_support/parsers/tests/test_sysfs_usb.py
index a47f0a7..bc3e14d 100644
--- a/checkbox_support/parsers/tests/test_sysfs_usb.py
+++ b/checkbox_support/parsers/tests/test_sysfs_usb.py
@@ -18,6 +18,8 @@
 
 
 """Tests for the sysfs_usb module."""
+import os
+import tempfile
 import textwrap
 
 from unittest import TestCase
@@ -58,12 +60,20 @@ class TestIsHex(TestCase):
 
 
 class TestUsbIds(TestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls._test_usb_ids = tempfile.NamedTemporaryFile(delete=False)
+
+    @classmethod
+    def tearDownClass(cls):
+        os.remove(cls._test_usb_ids.name)
+
     """Test for the UsbIds class."""
     def test_empty(self):
         """Test empty database."""
         mopen = mock_open(read_data='')
         with patch('builtins.open', mopen):
-            ids = UsbIds()
+            ids = UsbIds(self._test_usb_ids.name)
             with self.assertRaises(KeyError):
                 ids.decode_product(42, 42)
             self.assertEqual(ids.decode_protocol(42, 42, 42), '')
@@ -76,7 +86,7 @@ class TestUsbIds(TestCase):
         """)
         mopen = mock_open(read_data=usb_ids_content)
         with patch('builtins.open', mopen):
-            ids = UsbIds()
+            ids = UsbIds(self._test_usb_ids.name)
             self.assertEqual(ids.decode_product(0x42, 0x42), 'ACME Seafourium')
 
     def test_vendor_only(self):
@@ -86,7 +96,7 @@ class TestUsbIds(TestCase):
         """)
         mopen = mock_open(read_data=usb_ids_content)
         with patch('builtins.open', mopen):
-            ids = UsbIds()
+            ids = UsbIds(self._test_usb_ids.name)
             self.assertEqual(ids.decode_vendor(0x42), 'ACME')
 
     def test_full_protocol(self):
@@ -98,7 +108,7 @@ class TestUsbIds(TestCase):
         """)
         mopen = mock_open(read_data=usb_ids_content)
         with patch('builtins.open', mopen):
-            ids = UsbIds()
+            ids = UsbIds(self._test_usb_ids.name)
             self.assertEqual(ids.decode_protocol(0x42, 0x06, 0x01),
                              'Explosives:Bomb:Boom')
 
@@ -110,7 +120,7 @@ class TestUsbIds(TestCase):
         """)
         mopen = mock_open(read_data=usb_ids_content)
         with patch('builtins.open', mopen):
-            ids = UsbIds()
+            ids = UsbIds(self._test_usb_ids.name)
             self.assertEqual(ids.decode_protocol(0x42, 0x06, 0x01),
                              'Explosives:Bomb')
 
@@ -121,6 +131,6 @@ class TestUsbIds(TestCase):
         """)
         mopen = mock_open(read_data=usb_ids_content)
         with patch('builtins.open', mopen):
-            ids = UsbIds()
+            ids = UsbIds(self._test_usb_ids.name)
             self.assertEqual(ids.decode_protocol(0x42, 0x06, 0x01),
                              'Explosives')