Code review comment for ~sylvain-pineau/checkbox-support:fix-1830146

Revision history for this message
Taihsiang Ho (tai271828) wrote :

+1 the commit message is unexpected, ref https://git.launchpad.net/~sylvain-pineau/checkbox-support/commit/?id=9b4ffeeaf1676a0c1541825a79cbf7373df22746

I am soft +1 to joc's suggestion. Maybe we could use the index0 or index1 v4l/by-path/pci-0000:00:14.0-usb-0:5:1.2-video-indexX (X is 0 for the original device and 1 for the metadata one if I understand correctly).

Besides, the overall looks good to me and ready to land. (I personally wish to land asap so the soon coming sru test cycle could enjoy this fix)

review: Approve

« Back to merge proposal