Code review comment for ~sylvain-pineau/checkbox-support:run_watcher_systemd
Revision history for this message
| Jonathan Cave (jocave) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
My findings are that the code works perfectly *if* the systemd libraries used by the checkbox snap match the version of systemd that is running the system journal.
i.e. if the device is an Ubuntu Core 18 device then the checkbox snap must have been built on bionic and target core18. If the device is a Ubuntu Core 16 device the snap must have been built on xenial
Therefore I see no problem with the code, but I think we need firm plan on how we are going to test devices before landing this.