Checkbox Support Library

Code review comment for ~sylvain-pineau/checkbox-support:run_watcher_systemd

  1. Git
  2. lp:~sylvain-pineau/checkbox-support
  3. run_watcher_systemd
  4. Merge into master
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Code looks good. +1
And I love (+158/-480).

Total nitpick would be that some not perfect code got copied. Like string interpolation in logger calls and using .warning() when stuff is an error.

review: Approve

« Back to merge proposal