Merge ~sylvain-pineau/checkbox-support:usb_partion_hub_version into checkbox-support:master
Proposed by
Sylvain Pineau
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | 3d121ec03056e09fec11ab45e0ab4b3743f61ee6 |
Merged at revision: | e8696ddf6179ae41bdbf1270145d9440281ea297 |
Proposed branch: | ~sylvain-pineau/checkbox-support:usb_partion_hub_version |
Merge into: | checkbox-support:master |
Diff against target: |
17 lines (+6/-1) 1 file modified
checkbox_support/parsers/udevadm.py (+6/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Maciej Kisielewski (community) | Approve | ||
Review via email: mp+327870@code.launchpad.net |
Description of the change
This MR tweaks the bus property of PARTITION "devices". The original usb is kept for usb2 versions (needless to change the corresponding jobs using the removable_partition resource). But for usb3, the bus is then changed to usb3.
To test it, just run from the resource provider bin dir:
plainbox-
path: /devices/
name: sdb1
bus: usb3
category: PARTITION
product: sdb1
product_slug: sdb1
Note that a usb2 device plugged into a usb3 port will report bus: usb.
To post a comment you must log in.
Cool use of a for/else idiom!
Also LGTM, +1