Merge ~sylvain-pineau/checkbox-ng:fix-persmission-denied-nonroot-jobs into checkbox-ng:master

[Sylvain Pineau]

Fixes a bug where a slave service is running as root but with jobs executing with a regular user. In such cases, the jobs in question are not allowed to write data to CHECKBOX_DATA.

Eg:

bash: /root/.cache/plainbox/sessions/session_title-2019-11-07T07.19.25.session/CHECKBOX_DATA/cpuinfo_before_suspend: Permission denied

This patch fixes the problem.

[Sylvain Pineau (sylvain-pineau)]

self-approved

review: Approve

diff --git a/plainbox/impl/execution.py b/plainbox/impl/execution.py
index 38c1221..8c93f16 100644
--- a/plainbox/impl/execution.py
+++ b/plainbox/impl/execution.py
@@ -265,7 +265,9 @@ class UnifiedRunner(IJobRunner):
             extcmd_popen._delegate.on_end(proc.returncode)
             return proc.returncode
         if not os.path.isdir(os.path.join(self._session_dir, "CHECKBOX_DATA")):
+            oldmask = os.umask(000)
             os.makedirs(os.path.join(self._session_dir, "CHECKBOX_DATA"))
+            os.umask(oldmask)
         # Setup the executable nest directory
         with self.configured_filesystem(job) as nest_dir:
             # Get the command and the environment.
diff --git a/plainbox/impl/session/assistant.py b/plainbox/impl/session/assistant.py
index 4888730..8ef05e7 100644
--- a/plainbox/impl/session/assistant.py
+++ b/plainbox/impl/session/assistant.py
@@ -1328,7 +1328,9 @@ class SessionAssistant:
                 checkbox_data_dir = os.path.join(
                     self.get_session_dir(), 'CHECKBOX_DATA')
                 if not os.path.exists(checkbox_data_dir):
+                    oldmask = os.umask(000)
                     os.mkdir(checkbox_data_dir)
+                    os.umask(oldmask)
                 respawn_cmd_file = os.path.join(
                     checkbox_data_dir, '__respawn_checkbox')
                 if self._restart_cmd_callback: