Code review comment for ~sylvain-pineau/checkbox-ng:no_resource_no_templates

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Tested by adding a typo (s/name/foo)in the following job def:

unit: template
template-resource: fwts
plugin: shell
category_id: com.canonical.plainbox::firmware
id: firmware/fwts_{name}
estimated_duration: 1.2
requires: executable.name == 'fwts'
user: root
command: checkbox-support-fwts_test -t {foo} -l $PLAINBOX_SESSION_SHARE/fwts_{name}.log
_description: Run {name} test from Firmware Test Suite.
_summary: Run {name} test from Firmware Test Suite.

Checkbox still complains and issues the following warnings:

$ checkbox-cli run com.canonical.certification::client-cert-18-04
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
Ignoring firmware/fwts_{name} with missing template parameter foo
=========================[ Running Selected Test Plan ]=========================
-------------[ Running job 1 / 347. Estimated time left: unknown ]--------------
---------------[ Collect the hardware manifest (interactively) ]----------------
ID: com.canonical.plainbox::collect-manifest
Category: com.canonical.plainbox::uncategorised

« Back to merge proposal