Merge ~sylvain-pineau/checkbox-ng:fix-xlsx-missing-results into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 97730dbe31a4264205e3fbd8b15a8e21296487eb
Merged at revision: 0d7d57ed75752083656017114344dfef4b69e211
Proposed branch: ~sylvain-pineau/checkbox-ng:fix-xlsx-missing-results
Merge into: checkbox-ng:master
Diff against target: 31 lines (+3/-3)
1 file modified
plainbox/impl/exporter/xlsx.py (+3/-3)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+354300@code.launchpad.net

Description of the change

hotfix of the xlsx exporter, the test result worksheet was missing in standard exports.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/plainbox/impl/exporter/xlsx.py b/plainbox/impl/exporter/xlsx.py
index f582339..0e03f8b 100644
--- a/plainbox/impl/exporter/xlsx.py
+++ b/plainbox/impl/exporter/xlsx.py
@@ -794,7 +794,7 @@ class XLSXSessionStateExporter(SessionStateExporterBase):
794 if self.OPTION_WITH_SYSTEM_INFO in self._option_list:794 if self.OPTION_WITH_SYSTEM_INFO in self._option_list:
795 self.worksheet1 = self.workbook.add_worksheet(_('System Info'))795 self.worksheet1 = self.workbook.add_worksheet(_('System Info'))
796 self.write_systeminfo(data)796 self.write_systeminfo(data)
797 if not self.OPTION_TEST_PLAN_EXPORT:797 if not self.OPTION_TEST_PLAN_EXPORT in self._option_list:
798 self.worksheet3 = self.workbook.add_worksheet(_('Test Results'))798 self.worksheet3 = self.workbook.add_worksheet(_('Test Results'))
799 if (799 if (
800 self.OPTION_WITH_DESCRIPTION in self._option_list or800 self.OPTION_WITH_DESCRIPTION in self._option_list or
@@ -802,7 +802,7 @@ class XLSXSessionStateExporter(SessionStateExporterBase):
802 ):802 ):
803 self.worksheet4 = self.workbook.add_worksheet(803 self.worksheet4 = self.workbook.add_worksheet(
804 _('Test Descriptions'))804 _('Test Descriptions'))
805 if self.OPTION_TEST_PLAN_EXPORT:805 if self.OPTION_TEST_PLAN_EXPORT in self._option_list:
806 self.write_tp_export(data)806 self.write_tp_export(data)
807 else:807 else:
808 self.write_results(data)808 self.write_results(data)
@@ -812,7 +812,7 @@ class XLSXSessionStateExporter(SessionStateExporterBase):
812 if self.OPTION_WITH_TEXT_ATTACHMENTS in self._option_list:812 if self.OPTION_WITH_TEXT_ATTACHMENTS in self._option_list:
813 self.worksheet5 = self.workbook.add_worksheet(_('Log Files'))813 self.worksheet5 = self.workbook.add_worksheet(_('Log Files'))
814 self.write_attachments(data)814 self.write_attachments(data)
815 if not self.OPTION_TEST_PLAN_EXPORT:815 if not self.OPTION_TEST_PLAN_EXPORT in self._option_list:
816 self.worksheet6 = self.workbook.add_worksheet(_('Resources Logs'))816 self.worksheet6 = self.workbook.add_worksheet(_('Resources Logs'))
817 self.write_resources(data)817 self.write_resources(data)
818 for worksheet in self.workbook.worksheets():818 for worksheet in self.workbook.worksheets():

Subscribers

People subscribed via source and target branches