Merge ~sylvain-pineau/checkbox-ng:fix-1790050 into checkbox-ng:master

Proposed by Sylvain Pineau
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 9aaebc129d408b39b4c9bed92eccde1c79dcc3c1
Merged at revision: d45e00954b1af7038a452dff58912951d5508f75
Proposed branch: ~sylvain-pineau/checkbox-ng:fix-1790050
Merge into: checkbox-ng:master
Diff against target: 23 lines (+3/-2)
1 file modified
plainbox/impl/session/assistant.py (+3/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+354093@code.launchpad.net

Description of the change

Fixes linked bug by setting the runner class when resuming sessions

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

self-approved, tested on 18.04 with unfinished sessions. resuming succeeded

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/plainbox/impl/session/assistant.py b/plainbox/impl/session/assistant.py
index 995e38b..2595ae8 100644
--- a/plainbox/impl/session/assistant.py
+++ b/plainbox/impl/session/assistant.py
@@ -603,7 +603,8 @@ class SessionAssistant:
603 }603 }
604604
605 @raises(KeyError, UnexpectedMethodCall)605 @raises(KeyError, UnexpectedMethodCall)
606 def resume_session(self, session_id: str) -> 'SessionMetaData':606 def resume_session(self, session_id: str,
607 runner_cls=JobRunner) -> 'SessionMetaData':
607 """608 """
608 Resume a session.609 Resume a session.
609610
@@ -631,7 +632,7 @@ class SessionAssistant:
631 self._context = self._manager.default_device_context632 self._context = self._manager.default_device_context
632 self._metadata = self._context.state.metadata633 self._metadata = self._context.state.metadata
633 self._command_io_delegate = JobRunnerUIDelegate(_SilentUI())634 self._command_io_delegate = JobRunnerUIDelegate(_SilentUI())
634 self._init_runner()635 self._init_runner(runner_cls)
635 if self._metadata.running_job_name:636 if self._metadata.running_job_name:
636 job = self._context.get_unit(637 job = self._context.get_unit(
637 self._metadata.running_job_name, 'job')638 self._metadata.running_job_name, 'job')

Subscribers

People subscribed via source and target branches