Merge ~sylvain-pineau/checkbox-core-snap:full-i2c-tools into checkbox-core-snap:master

[Sylvain Pineau]

On bionic all i2c tests are failing because we can't load a shared library:

i2cdetect: error while loading shared libraries: libi2c.so.0: cannot open shared object file: No such file or directory

It does not happen on uc16 as there no such split between i2c tools and libs, executables are self-contained and https://packages.ubuntu.com/bionic/libi2c0 does not even exist.

[Gavin Lin (gavin.lin)]

+1, since it's required on bionic.

review: Approve

diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
index 8383afb..5efae38 100644
--- a/snap/snapcraft.yaml
+++ b/snap/snapcraft.yaml
@@ -189,6 +189,7 @@ parts:
       - gstreamer1.0-pulseaudio
       - try: [hdapsd] # optional as not available for arm
       - hdparm
+      - i2c-tools
       - ipmitool
       - iperf
       - iperf3
@@ -282,13 +283,6 @@ parts:
       - curl
     after: [plainbox-provider-engineering-tests]
 ################################################################################
-  i2c-tools:
-    plugin: nil
-    stage-packages:
-      - i2c-tools
-    prime:
-      - usr/sbin/i2cdetect
-################################################################################
   # This module is a dependency for the job gpio/gpiomem_loopback_pairs_{model}
   # in plainbox-provider-snappy only available in pypi and so can't be addded
   # to stage-packages