Code review comment for lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

On 03/23/2014 11:42 PM, Sylvain LE GAL (GRAP) wrote:
> Hi Guewen,
>
> I changed import call.
>
> About the reload, the self.do_action('reload') doesn't work. I think because I'm in a instance.web.Widget class.
> Can you say me how to call this function ? I 'rgreped' 'do_action' in web-addons without results.

You will find many occurrences if you grep for rgrep "do_action(.*)" ./
You won't find it if you grep for rgrep "do_action('reload')" ./ because it is never passed directly as a constant, but always called using client actions from the server.

>
> As Arthru said, openerp call window.location.reload().
> rgrep "window.*reload" ./ gives 3 references in openerp-web project.
It does that when the user logs out or when closing the view editor. I don't know what is the correct way to reload the page, maybe the client action is only for reloading from the server, when a window.location.reload() is sufficient.
>
> Regards.

review: Approve

« Back to merge proposal