Code review comment for lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company

Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

Hi all,

I propose for merging this little module I did, that allow users to switch from a company to another more easily.

2 questions :

1/ l242, I wrote "window.location.reload()" to reload the page after the change of the value 'company_id' of the current user. It works fine but I wonder if there is a solution more elegant ? A function in the openERP framework ?

2/ By default, the name of the current company is displayed with parenthesis, after the name of the current user, if company_id >1 ... (pretty weird)
http://bazaar.launchpad.net/~openerp/openerp-web/7.0/view/head:/addons/web/static/src/js/chrome.js#L1117
I would like to remove the name of the company (because my module display it in all case) but the operation is realized asynchroneously after a ".then" (L1113).
So I found 3 solutions that I do not like :
A/ overload 'do_update' function and change the text after a 'setTimeout' of x seconde ... ; (-> not predictive / ugly)
B/ rewrite the 'do_update' function entirely ; (-> not modular)
C/ Do nothing ; (-> not a solution ;-) )

Do you have some ideas about that 2 questions ?

thanks for your review.

« Back to merge proposal