Merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:~server-env-tools-core-editors/server-env-tools/7.0
Proposed by
Sylvain LE GAL (GRAP)
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp |
Approved revision: | 79 |
Merged at revision: | 77 |
Proposed branch: | lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 |
Merge into: | lp:~server-env-tools-core-editors/server-env-tools/7.0 |
Diff against target: |
145 lines (+123/-1) 3 files modified
auth_admin_passkey/model/res_users.py (+1/-1) auth_admin_passkey/tests/__init__.py (+23/-0) auth_admin_passkey/tests/test_auth_admin_passkey.py (+99/-0) |
To merge this branch: | bzr merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Yannick Vaucher @ Camptocamp | code review, no test | Approve | |
Pedro Manuel Baeza | code review | Approve | |
Maxime Chambreuil (http://www.savoirfairelinux.com) | Approve | ||
Review via email: mp+219530@code.launchpad.net |
Commit message
[ADD] Regression Tests;
[FIX] Uncaught error is raised when the admin user tries to connect with a bad login and his password;
[ADD] Test for the fixed bug;
Description of the change
Hi all,
I propose for merging this code to fix the bug https:/
I added Test files to :
- avoid regressions;
- to give the possibility to the community to test more easily this module with other 'auth_...' module;
Regards.
To post a comment you must log in.
LGTM, thanks.
Regards.