Hi Sylvain, another great contribution! Some remarks from a quick scan:
- Typos in description file:
s/Functionnalities/Functionality s/Technical informations/Technical information
- I'm not sure about putting company information in description. We have author and website fields for that. What others think about it?
- On __init__.py, please use 'from . import xxx' form.
- Please respect PEP8 max line width (79 cols) in res_config.py (maybe with shorter field names).
- You can use self.pool['object.name'] instead of self.pool.get('object.name') to get a shorter form and exact traceback when a model doesn't exist.
-
« Back to merge proposal
Hi Sylvain, another great contribution! Some remarks from a quick scan:
- Typos in description file:
s/Functionnalit ies/Functionali ty Technical information
s/Technical informations/
- I'm not sure about putting company information in description. We have author and website fields for that. What others think about it?
- On __init__.py, please use 'from . import xxx' form.
- Please respect PEP8 max line width (79 cols) in res_config.py (maybe with shorter field names).
- You can use self.pool[ 'object. name'] instead of self.pool. get('object. name') to get a shorter form and exact traceback when a model doesn't exist.
-