OpenUpgrade Addons

Merge lp:~sylvain-legal/openupgrade-addons/7.0-account_fix_rename_xmlids into lp:openupgrade-addons

  1. 7.0-account_fix_rename_xmlids
  2. Merge into 7.0
Proposed by Sylvain LE GAL (GRAP)
Status: Merged
Merged at revision: 8133
Proposed branch: lp:~sylvain-legal/openupgrade-addons/7.0-account_fix_rename_xmlids
Merge into: lp:openupgrade-addons
Diff against target: 8 lines (+1/-0)
1 file modified
account/migrations/7.0.1.1/pre-migration.py (+1/-0)
To merge this branch: bzr merge lp:~sylvain-legal/openupgrade-addons/7.0-account_fix_rename_xmlids
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Review via email: mp+183711@code.launchpad.net

Commit message

[FIX] call 'rename_xmlids' function in pre-migration script.

Description of the change

I think it lakes the call to the function 'rename_xmlids' in the 'pre-migration.py' script.

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Good catch, thanks!

review: Approve
Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

You're welcome.

By the way, I have a little problem with my last merge proposal. There are
"cumulative".
I did a mistake, because I don't control very good bazaar / launchpad
functionnalities...

I will revise it as soon as possible.

Bye.

[image: logo] *Sylvain LE GAL
* Service informatique
  *GRAP* SCIC SARL *Groupement Régional Alimentaire de Proximité* 3
Grande rue des feuillants 69001 Lyon Bureau : (+33) 09.72.32.33.17
Astreinte : (+33) 06.81.85.61.43 www.grap.coop
www.python-openerp.fr

2013/9/5 Stefan Rijnhart (Therp) <email address hidden>

> Review: Approve
>
> Good catch, thanks!
>
> --
>
> https://code.launchpad.net/~sylvain-legal/openupgrade-addons/7.0-account_fix_rename_xmlids/+merge/183711
> You are the owner of
> lp:~sylvain-legal/openupgrade-addons/7.0-account_fix_rename_xmlids.
>

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Oh, I noticed you merged your own work. In line with the community reviewers policy I would like to propose not to do that in the future, just to be sure that there are always multiple contributors involved. Sorry to tell you so late ;-)

Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

Hi.

I allowed myself to merge my own work because it was a very simple merge. (1 line added) and I was working on other works on the same 'account' folder (account-with-cashbox) and i needed that line. (to avoid multiple branches with conflict).
But OK ! Sorry & I will not do again.

+++

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account/migrations/7.0.1.1/pre-migration.py'
2--- account/migrations/7.0.1.1/pre-migration.py 2013-07-24 12:41:33 +0000
3+++ account/migrations/7.0.1.1/pre-migration.py 2013-09-03 16:45:36 +0000
4@@ -42,3 +42,4 @@
5 @openupgrade.migrate()
6 def migrate(cr, version):
7 openupgrade.rename_columns(cr, column_renames)
8+ openupgrade.rename_xmlids(cr, xmlid_renames)

Subscribers

People subscribed via source and target branches