Merge lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick into lp:openlp
Status: | Merged |
---|---|
Approved by: | Tim Bentley |
Approved revision: | 2707 |
Merged at revision: | 2698 |
Proposed branch: | lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick |
Merge into: | lp:openlp |
Diff against target: |
151 lines (+77/-9) 4 files modified
openlp/core/ui/exceptiondialog.py (+3/-3) openlp/plugins/bibles/lib/manager.py (+0/-1) openlp/plugins/bibles/lib/mediaitem.py (+16/-4) tests/functional/openlp_plugins/bibles/test_mediaitem.py (+58/-1) |
To merge this branch: | bzr merge lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Bentley | Approve | ||
Tomas Groth | Approve | ||
Raoul Snyman | Approve | ||
Phill | Approve | ||
Review via email: mp+306037@code.launchpad.net |
This proposal supersedes a proposal from 2016-09-17.
Description of the change
Fixed the issue where web bible's result in traceback in "Search while typing"
(by removing one miss-placed line)
This branch also fixes the issue where the new "Clear Bible search results" and
"Lock button" give focus to Text search if it is used in "Select" tab.
lp:~suutari-olli/openlp/fix-advanced-bible-search-clear-button-giving-focus-to-quick (revision 2707)
[[1;32mSUCCESS
[[1;32mSUCCESS
[[1;32mSUCCESS
[[1;32mSUCCESS
[[1;32mSUCCESS
[[1;32mSUCCESS
[[1;32mSUCCESS
[[1;32mSUCCESS
Looks OK but needs tests!