Ubuntu

Merge lp:~surfacepatterns/ubuntu/quantal/rtmidi/add-alsa-support into lp:ubuntu/quantal/rtmidi

Proposed by Devin Anderson on 2012-12-30
Status: Rejected
Rejected by: Stéphane Graber on 2013-01-31
Proposed branch: lp:~surfacepatterns/ubuntu/quantal/rtmidi/add-alsa-support
Merge into: lp:ubuntu/quantal/rtmidi
Diff against target: 48 lines (+10/-2) 3 files modified
To merge this branch: bzr merge lp:~surfacepatterns/ubuntu/quantal/rtmidi/add-alsa-support
Reviewer Review Type Date Requested Status
Luke Yelavich Disapprove on 2013-01-29
Ubuntu branches 2012-12-30 Pending
Review via email: mp+141471@code.launchpad.net

Description of the Change

Add ALSA support to rtmidi.

To post a comment you must log in.
Oliver Grawert (ogra) wrote :

while the patch itself does not look harmful, how about the binaries this produces, have they been tested to not have regressions in the context they are usually used ?

since this is a merge request for quantal (https://wiki.ubuntu.com/StableReleaseUpdates) can you:

a) file an SRU bug according to the above process
b) prepare the same patch for raring (13.04) since SRUs require that the code is in the development release first

Devin Anderson (surfacepatterns) wrote :

Hi Oliver,

On Thu, Jan 24, 2013 at 5:59 AM, Oliver Grawert <email address hidden> wrote:

> while the patch itself does not look harmful, how about the binaries
> this produces, have they been tested to not have regressions in the
> context they are usually used ?

I've tested the changes against `midisnoop`, an application I wrote to
monitor and probe MIDI ports. Using `midisnoop`, I've done the
following with both the JACK and ALSA drivers:

    * opened and closed MIDI ports, both named and virtual

    * sent and received MIDI messages, including system exclusive messages
    (some of which the JACK driver doesn't handle due to the limitations of
    JACK MIDI)

    * switching back and forth between the JACK and ALSA drivers multiple
    times during the same execution

All of the code that interacts with the RtMidi library can be found here:

    https://code.google.com/p/midisnoop/source/browse/src/engine.cpp

... and here:

    https://code.google.com/p/midisnoop/source/browse/src/engine.h

> since this is a merge request for quantal
> (https://wiki.ubuntu.com/StableReleaseUpdates) can you:
>
> a) file an SRU bug according to the above process
> b) prepare the same patch for raring (13.04) since SRUs
> require that the code is in the development release first

I can, but I don't know when I'll find time to do it.

Thanks,

--
Devin Anderson
surfacepatterns (at) gmail (dot) com

blog - http://surfacepatterns.blogspot.com/
midisnoop - http://midisnoop.googlecode.com/
psinsights - http://psinsights.googlecode.com/
synthclone - http://synthclone.googlecode.com/

Devin Anderson (surfacepatterns) wrote :

Hi Oliver,

On Thu, Jan 24, 2013 at 8:35 PM, Devin Anderson
<email address hidden> wrote:

>> since this is a merge request for quantal
>> (https://wiki.ubuntu.com/StableReleaseUpdates) can you:
>>
>> a) file an SRU bug according to the above process
>> b) prepare the same patch for raring (13.04) since SRUs
>> require that the code is in the development release first
>
> I can, but I don't know when I'll find time to do it.

I pushed a branch for 'raring':

    https://code.launchpad.net/~surfacepatterns/ubuntu/raring/rtmidi/add-alsa-support

It's identical to the 'quantal' branch. AFAICT, the packages are the
same. However, I'm new to package creation for Ubuntu, so it's
possible I missed something.

The documentation on the SRU suggests that changes can only be made
for "high-impact bugs". I'm not sure that enabling ALSA support fixes
any particular bug, save that the documentation on RtMidi and Ubuntu's
RtMidi package differ on ALSA support. I suppose the issue might fit
under:

    * Bugs which do not fit under above categories, but (1) have an
    obviously safe patch and (2) affect an application rather than critical
    infrastructure packages (like X.org or the kernel).

The point here is that I'm not sure if I should file an SRU, given the
"high-impact bug" requirement. If you still feel it's the right way
to go, then I'll do it.

Thanks,

--
Devin Anderson
surfacepatterns (at) gmail (dot) com

blog - http://surfacepatterns.blogspot.com/
midisnoop - http://midisnoop.googlecode.com/
psinsights - http://psinsights.googlecode.com/
synthclone - http://synthclone.googlecode.com/

Luke Yelavich (themuso) wrote :

With regards to quantal, I feel that this would be considered new functionality, which is frowned upon for stable updates, so I don't think the SRU team would let this through.

As for raring, its better to get this change directly into Debian, where a lot of multimedia packages are maintained for both Debian and Ubuntu. Since I have commit access to the debian vcs for the packaging, I committed your change there, so both Debian and Ubuntu will benefit from this change.

Thanks for your work, marking this branch proposal as disapprove given its for quantal, but this change should be in raring very shortly.

review: Disapprove

Unmerged revisions

6. By Devin Anderson on 2012-12-30

debian/control, debian/rules: build rtmidi with ALSA bindings

Preview Diff

1=== modified file 'debian/changelog'
2--- debian/changelog 2012-08-02 13:41:05 +0000
3+++ debian/changelog 2012-12-30 01:14:20 +0000
4@@ -1,3 +1,9 @@
5+rtmidi (2.0.1~ds0-1ubuntu1) UNRELEASED; urgency=low
6+
7+ * debian/control, debian/rules: build rtmidi with ALSA bindings
8+
9+ -- Devin Anderson <surfacepatterns@gmail.com> Sat, 29 Dec 2012 17:00:44 -0800
10+
11 rtmidi (2.0.1~ds0-1) experimental; urgency=low
12
13 * New upstream release.
14
15=== modified file 'debian/control'
16--- debian/control 2012-07-18 15:20:42 +0000
17+++ debian/control 2012-12-30 01:14:20 +0000
18@@ -6,7 +6,8 @@
19 Build-Depends:
20 debhelper (>= 8.1.3~),
21 dh-autoreconf,
22- libjack-dev
23+ libjack-dev,
24+ libasound2-dev
25 Standards-Version: 3.9.3
26 Homepage: http://www.music.mcgill.ca/~gary/rtmidi/
27 Vcs-Git: git://git.debian.org/pkg-multimedia/rtmidi.git
28@@ -48,6 +49,7 @@
29 Multi-Arch: same
30 Depends:
31 libjack-dev,
32+ libasound2-dev,
33 librtaudio-dev,
34 librtmidi1 (= ${binary:Version}),
35 ${misc:Depends},
36
37=== modified file 'debian/rules'
38--- debian/rules 2012-07-18 15:20:42 +0000
39+++ debian/rules 2012-12-30 01:14:20 +0000
40@@ -3,7 +3,7 @@
41 export REPACK_SH=$(CURDIR)/debian/repack.sh
42 DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
43 DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
44-CONFIGURE_FLAGS = --with-jack
45+CONFIGURE_FLAGS = --with-alsa --with-jack
46
47 CFLAGS += -g
48 ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))

Subscribers

People subscribed via source and target branches